lengyuexuexuan opened a new issue, #1881:
URL: https://github.com/apache/incubator-pegasus/issues/1881

   
   This change was made in December 2023.
   
   Currently, if users fetch the source code and build it themselves, there are 
a few issues:
   
   The Go client requires go version 1.18+, and thrift version 0.13.0. If users 
decide to upgrade, they may also need to update these two packages, which could 
be a bit troublesome.
   
   When compiling the Go client, the process relies on files under the "idl" 
directory within the "pegasus" directory. The relevant commands in the makefile 
for this part are as follows:
   ```
   build:    thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/backup.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/bulk_load.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/dsn.layer2.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/duplication.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/meta_admin.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/metadata.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/partition_split.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/replica_admin.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/rrdb.thrift
       thrift -I ../idl -out idl --gen 
go:thrift_import='github.com/apache/thrift/lib/go/thrift',package_prefix='github.com/apache/incubator-pegasus/go-client/idl/'
 ../idl/command.thrift
   ```
   Therefore, if users compile it themselves, they also need to clone all of 
the Pegasus code. Is this too complex for users?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to