acelyc111 commented on code in PR #1908:
URL:
https://github.com/apache/incubator-pegasus/pull/1908#discussion_r1522593316
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -59,6 +60,11 @@ METRIC_DEFINE_counter(replica,
dsn::metric_unit::kRequests,
"The number of failed DUPLICATE requests sent from
client");
+METRIC_DEFINE_counter(replica,
+ dup_retry_non_idempotent_duplicate_request,
+ dsn::metric_unit::kRequests,
+ "The qps of Non-idempotent write when doing DUPLICATE
which is Retried");
Review Comment:
Maybe ?
```suggestion
"The number of retried non-idempotent DUPLICATE
requests sent from client");
```
##########
src/common/duplication_common.cpp:
##########
@@ -37,6 +37,13 @@ DSN_DEFINE_uint32(replication,
"send mutation log batch bytes size per rpc");
DSN_TAG_VARIABLE(duplicate_log_batch_bytes, FT_MUTABLE);
+DSN_DEFINE_bool(replication,
+ force_send_non_idempotent_when_duplication,
Review Comment:
To keep the coding style and convenient distinguish which component the
config belongs to, it would be better to rename config names in duplication as
`duplication_xxx`, metric names as `dup_xxx`.
For example, force_send_non_idempotent_when_duplication ->
duplication_unsafe_allow_non_idempotent, the "unsafe" stands by issue may
caused the retry mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
