empiredan commented on code in PR #1608:
URL:
https://github.com/apache/incubator-pegasus/pull/1608#discussion_r1546271870
##########
src/replica/duplication/duplication_sync_timer.cpp:
##########
@@ -75,9 +79,13 @@ void duplication_sync_timer::run()
// collects confirm points from all primaries on this server
for (const replica_ptr &r : get_all_primaries()) {
Review Comment:
Actually both `get_all_primaries()` and `get_all_replicas()` are operating
the members of `replica_stub`, thus it's better to move both of them to
`replica_stub`. I'll create [another
pr](https://github.com/apache/incubator-pegasus/pull/1967) to refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
