acelyc111 commented on code in PR #1997:
URL:
https://github.com/apache/incubator-pegasus/pull/1997#discussion_r1619652779
##########
java-client/pom.xml:
##########
@@ -470,6 +470,36 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>thrift-maven-plugin</artifactId>
+ <version>0.10.0</version>
Review Comment:
For compatibility reason, it's recommend to use 0.11.0 version.
##########
java-client/scripts/download_thrift.sh:
##########
@@ -48,21 +48,4 @@ if ! $thrift -version | grep "0.11.0" ; then
exit 1
fi
-TMP_DIR=./gen-java
Review Comment:
It seems `thrift` will not be used any where in java-client, can we remove
this file entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
