Samunroyu commented on code in PR #2034:
URL:
https://github.com/apache/incubator-pegasus/pull/2034#discussion_r1619759905
##########
scripts/pack_server.sh:
##########
@@ -109,8 +109,28 @@ while [[ $# > 0 ]]; do
shift
done
+if [[ $separate_servers == "false" ]] && [[ ! -f
${BUILD_LATEST_DIR}/output/bin/pegasus_server/pegasus_server ]]; then
+ echo "ERROR: ${BUILD_LATEST_DIR}/output/bin/pegasus_server/pegasus_server
not found"
+ exit 1
+fi
+
+if [[ $separate_servers == "true" ]] && [[ ! -f
${BUILD_LATEST_DIR}/output/bin/pegasus_meta_server/pegasus_meta_server ]]; then
+ echo "ERROR:
${BUILD_LATEST_DIR}/output/bin/pegasus_meta_server/pegasus_meta_server not
found"
+ exit 1
+fi
+
+if [[ $separate_servers == "true" ]] && [[ ! -f
${BUILD_LATEST_DIR}/output/bin/pegasus_replica_server/pegasus_replica_server
]]; then
+ echo "ERROR:
${BUILD_LATEST_DIR}/output/bin/pegasus_replica_server/pegasus_replica_server
not found"
+ exit 1
+fi
Review Comment:
> Will `copy_file` throw an error if the source file not exist? You can
remove the manual judgements if it will.
`copu_file` will throw an error if the source file not exist, i already
remove those manual judgements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
