acelyc111 commented on code in PR #2077:
URL:
https://github.com/apache/incubator-pegasus/pull/2077#discussion_r1692608269
##########
src/replica/bulk_load/replica_bulk_loader.cpp:
##########
@@ -534,7 +534,26 @@ void replica_bulk_loader::download_sst_file(const
std::string &remote_dir,
int32_t file_index,
dist::block_service::block_filesystem *fs)
{
- const file_meta &f_meta = _metadata.files[file_index];
+ if (_status != bulk_load_status::BLS_DOWNLOADING) {
+ LOG_WARNING_PREFIX("Cancel download_sst_file task, because bulk_load
local_status is {}. "
+ "local_dir: {} , file_index is {}.",
+ enum_to_string(_status),
+ local_dir,
+ file_index);
+ return;
+ }
+ file_meta f_meta;
+ {
+ zauto_read_lock l(_lock);
+ if (file_index < _metadata.files.size()) {
+ f_meta = _metadata.files[file_index];
+ }
+ }
+ if (f_meta.name.empty()) {
Review Comment:
How can this happen? Has the `_metadata` changed?
##########
src/replica/bulk_load/replica_bulk_loader.cpp:
##########
@@ -534,7 +534,30 @@ void replica_bulk_loader::download_sst_file(const
std::string &remote_dir,
int32_t file_index,
dist::block_service::block_filesystem *fs)
{
- const file_meta &f_meta = _metadata.files[file_index];
+ if (_status != bulk_load_status::BLS_DOWNLOADING) {
+ LOG_WARNING_PREFIX("Cancel download_sst_file task, because bulk_load
local_status is {}. "
+ "local_dir: {} , file_index is {}.",
Review Comment:
>
Why not update this? It's not a good idea to use varible names in logs, the
common administators don't know what do they mean.
Keep in mind that there are difference between users, administators and
developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
