acelyc111 commented on code in PR #2099: URL: https://github.com/apache/incubator-pegasus/pull/2099#discussion_r1721379193
########## src/replica/duplication/duplication_pipeline.cpp: ########## @@ -17,22 +17,29 @@ #include "duplication_pipeline.h" -#include <string_view> -#include <stddef.h> #include <algorithm> +#include <chrono> +#include <cstddef> #include <functional> #include <string> +#include <string_view> #include <utility> #include "load_from_private_log.h" #include "replica/duplication/replica_duplicator.h" #include "replica/mutation_log.h" #include "replica/replica.h" -#include "runtime/rpc/rpc_holder.h" #include "utils/autoref_ptr.h" #include "utils/errors.h" +#include "utils/flags.h" #include "utils/fmt_logging.h" +DSN_DEFINE_uint64( + replication, + dup_no_mutation_load_delay_ms, + 100, + "The duration of the delay until the next execution if there is no mutation to be loaded."); Review Comment: Mark it as FT_MUTABLE then we can modify it at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
