ninsmiracle commented on code in PR #2103:
URL:
https://github.com/apache/incubator-pegasus/pull/2103#discussion_r1726960500
##########
src/utils/configuration.h:
##########
@@ -43,11 +44,68 @@ namespace dsn {
class configuration
{
+private:
+ struct conf
+ {
+ std::string section;
+ std::string key;
+ std::string value;
+ int line;
+
+ bool present;
Review Comment:
At begin I declaring `configuration(config_map&)` to use the mutex lock the
map. If I not move private parameter before public function, an error will be
reported during the compilation phase: the variable cannot be found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
