empiredan commented on code in PR #2110:
URL:
https://github.com/apache/incubator-pegasus/pull/2110#discussion_r1744920519
##########
src/utils/blob.h:
##########
@@ -109,7 +109,15 @@ class blob
/// NOTE: this operation is not efficient since it involves a memory copy.
[[nodiscard]] static blob create_from_bytes(const char *s, size_t len)
{
- CHECK_NOTNULL(s, "null source pointer would lead to undefined
behaviour");
+ if (s == nullptr) {
Review Comment:
OK, I dropped this and use `DCHECK` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
