acelyc111 commented on code in PR #2126:
URL:
https://github.com/apache/incubator-pegasus/pull/2126#discussion_r1901409768
##########
src/nfs/nfs_code_definition.h:
##########
@@ -24,21 +24,20 @@
* THE SOFTWARE.
*/
+#include "task/task_code.h"
#pragma once
-namespace dsn {
-namespace service {
+namespace dsn::service {
// define RPC task code for service 'nfs'
-DEFINE_TASK_CODE_RPC(RPC_NFS_COPY, TASK_PRIORITY_COMMON,
::dsn::THREAD_POOL_DEFAULT)
-DEFINE_TASK_CODE_RPC(RPC_NFS_GET_FILE_SIZE, TASK_PRIORITY_COMMON,
::dsn::THREAD_POOL_DEFAULT)
+DEFINE_TASK_CODE_RPC(RPC_NFS_COPY, TASK_PRIORITY_COMMON,
::dsn::THREAD_POOL_BLOCK_SERVICE)
Review Comment:
This is the core change of this patch, make the *NFS* tasks to use
THREAD_POOL_BLOCK_SERVICE thread pool instead of THREAD_POOL_DEFAULT thread
pool, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
