empiredan commented on code in PR #2172:
URL:
https://github.com/apache/incubator-pegasus/pull/2172#discussion_r1910202534
##########
src/client/replication_ddl_client.h:
##########
@@ -95,22 +95,59 @@ class replication_ddl_client
error_with<configuration_rename_app_response> rename_app(const std::string
&old_app_name,
const std::string
&new_app_name);
- dsn::error_code list_apps(const dsn::app_status::type status,
- bool show_all,
- bool detailed,
- bool json,
- const std::string &file_name);
-
- dsn::error_code list_apps(const dsn::app_status::type status,
- std::vector<::dsn::app_info> &apps);
-
- dsn::error_code list_nodes(const dsn::replication::node_status::type
status,
- bool detailed,
- const std::string &file_name,
- bool resolve_ip = false);
-
+ // Choose tables and list them to a file, with path specified as
`output_file`. Once
+ // `output_file` is empty, tables would be listed to stdout.
+ //
+ // Choose tables according to following parameters:
+ // `show_all`: whether to show all tables, not only the available, but
also the ones in
+ // other status, e.g. the dropped tables.
+ // `detailed`: whether to show healthy/unhealthy details.
+ // `json`: whether to output as json format.
+ // `status`: the status of the tables chosen to be listed.
`app_status::AS_INVALID` means
+ // no restriction.
+ // `app_name_pattern`: the name pattern of the tables chosen to be listed.
+ // `match_type`: the type in which the name pattern would be matched.
+ error_s list_apps(bool show_all,
+ bool detailed,
+ bool json,
+ const std::string &output_file,
+ dsn::app_status::type status,
+ const std::string &app_name_pattern,
+ utils::pattern_match_type::type match_type);
+
+ // The same as the above, except that there's no restriction on table
name; in other
+ // words, the match type is `PMT_MATCH_ALL`.
+ error_s list_apps(bool show_all,
+ bool detailed,
+ bool json,
+ const std::string &output_file,
+ dsn::app_status::type status);
+
+ // Create and send request to meta server to get the tables chosen to be
listed according
+ // to the following parameters:
+ // `status`: the status of the tables chosen to be listed.
`app_status::AS_INVALID` means
+ // no restriction.
+ // `app_name_pattern`: the name pattern of the tables chosen to be listed.
+ // `match_type`: the type in which the name pattern would be matched.
Review Comment:
OK, I'll remove the repeated comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
