empiredan commented on code in PR #2249:
URL:
https://github.com/apache/incubator-pegasus/pull/2249#discussion_r2108133307
##########
src/server/pegasus_write_service.h:
##########
@@ -217,6 +234,28 @@ class pegasus_write_service :
dsn::replication::replica_base
// Finish batch write with metrics such as latencies calculated and some
states cleared.
void batch_finish();
+ // Used to store the batch size for each type of write into an array, see
comments for
+ // `_batch_sizes` for details.
+ enum class batch_write_type : uint32_t
+ {
+ put = 0,
+ remove,
+ incr,
+ check_and_set,
+ check_and_mutate,
+ count,
Review Comment:
OK. Actually now `count` is used only in `std::array<uint32_t,
static_cast<size_t>(batch_write_type::count)> _batch_sizes{};`. So we can make
it all-caps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
