WJSGDBZ commented on PR #2304:
URL: 
https://github.com/apache/incubator-pegasus/pull/2304#issuecomment-3449336766

   > If the client side timeout is unset, it seems it will be filled as 
`rpc_timeout_milliseconds`, what does `rpc_timeout_milliseconds` set in your 
environment?
   > 
   > 
https://github.com/apache/incubator-pegasus/blob/0fc00015a217da8a158b3cd1f1bafd9ab6631f7d/src/rpc/rpc_message.cpp#L299-L303
   
   In the function ```message_ex::create_request```, it appears from "Find All 
References" that this function is used by the server to create requests 
intended for RPC transmission. However, I couldn't seem to find any reference 
to this function in the RPC parsing logic. 
   
   On the server side, during message reception, the server calls 
```asio_rpc_session::do_read```, which in turn invokes 
```thrift_message_parser::get_message_on_receive```. For Thrift requests, the 
timeout value is set within the function 
```thrift_message_parser::parse_request_body_v1```,this function will create 
```message_ex``` object.
   
https://github.com/apache/incubator-pegasus/blob/0fc00015a217da8a158b3cd1f1bafd9ab6631f7d/src/rpc/thrift_message_parser.cpp#L282
   
   We ran a test to double-check this behavior, and observed that when this 
parameter is set, all client requests appear to time out. 
   
https://github.com/apache/incubator-pegasus/blob/fdbd6ebb460b97d39c027837217c1a41de1b3671/src/server/config.ini#L557
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to