Samunroyu commented on PR #2317: URL: https://github.com/apache/incubator-pegasus/pull/2317#issuecomment-3515534725
> > Why do we need to clear partitions in migration info ?Is the old partitions info will appear on the outputting result if we dont clear partition? > > As a parameter of the `get_app_migration_info` function, `info` serves purely as an output parameter. `info.partitions` is expected to be empty and used to store the output results. > > Before [the refactoring](https://github.com/apache/incubator-pegasus/pull/2051), the code first resized it and then assigned values to each element one by one, as shown [here](https://github.com/acelyc111/pegasus/blob/a684b43d99626667b9725833a4c102d9d8dd3805/src/meta/cluster_balance_policy.cpp#L226). i see. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
