ruojieranyishen opened a new pull request, #2395:
URL: https://github.com/apache/incubator-pegasus/pull/2395
## Summary
Fix CI startup failures for release branches (e.g., v2.5) that don't have
prebuilt Docker images.
## Problem
The workflow `lint_and_test_cpp.yaml` used `\${{ github.base_ref }}` to
construct Docker image tags:
- \`apache/pegasus:thirdparties-bin-test-ubuntu2204-v2.5\` (doesn't exist!)
This caused \`startup_failure\` for PRs targeting release branches like v2.5.
## Solution
Hardcode all Docker image tags to use \`master\` branch images, which:
1. Always exist and are up-to-date
2. Should be compatible with release branches (same thirdparty dependencies)
## Changes
- Updated Docker image tags in jobs: Tidy, IWYU, Build/Test Release, ASAN,
jemalloc, Rockylinux9
- clang-tidy now compares against \`origin/master\` instead of
\`origin/base_ref\`
- Added explanatory comment at the top of the workflow file
## Testing
The change only affects CI configuration. No code changes to C++ source.
## Related
This fix enables CI for cherry-pick PRs targeting v2.5 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
