nvollmar commented on code in PR #2:
URL: https://github.com/apache/incubator-pekko/pull/2#discussion_r1012521720
##########
akka-remote/src/main/scala/akka/remote/Remoting.scala:
##########
@@ -744,7 +744,7 @@ private[remote] class EndpointManager(conf: Config, log:
LoggingAdapter)
endpoint ! s
case Some(Gated(timeOfRelease)) =>
if (timeOfRelease.isOverdue()) createAndRegisterWritingEndpoint() ! s
- else extendedSystem.deadLetters ! s
+ else extendedSystem.deadLetters ! s
Review Comment:
I don't think this is an improvement. In such a case it would probably be
better to manually reformat the if/else to separate lines to keep things more
in line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
