> One of the criteria to vote on a release is to successfully compile it. If it complex to do that or it requires prerequisites that people may not use or be familiar with or not have installed that may make it hard to get votes. Hopefully this won’t be an issue.
Understood, but as mentioned before there is nothing Pekko can do about this. To properly build all of the artifacts within Pekko core for a release it requires multiple JDK's to be installed at once on the host machine (this is mainly due to a backwards breaking change that was introduced in JDK 11 and Pekko currently supports JDK 8). Even if JDK 8 support gets dropped, there are other build/release specific features that would need to be supplied (i.e. inlining). Note that I am making a distinction between compiling and making a release build, currently nothing is preventing people from compiling Pekko locally (this is how people develop locally). However if we want to make a release build (which is in the form of jar's) the steps detailed beforehand are necessary. The whole reason why Docker is being used here is that it's a lot more trivial compared to other options (i.e. VM's, documenting different solutions for different OS's using different tools like sdkman etc). On Mon, May 22, 2023 at 10:57 AM Justin Mclean <[email protected]> wrote: > Hi, > > One of the criteria to vote on a release is to successfully compile it. If > it complex to do that or it requires prerequisites that people may not use > or be familiar with or not have installed that may make it hard to get > votes. Hopefully this won’t be an issue. > > Kind Regards, > Justin > > > On 22 May 2023, at 5:14 pm, Matthew Benedict de Detrich < > [email protected]> wrote: > > > >> I’m not sure if this is the case, but requiring docker to check the > > release may be a barrier to getting IPMC votes on your release. > > > > Docker is required to make a correct and reproducible build of Pekko > > because Pekko requires multiple JDK's to be installed on the host > > systems, if this is not the case then some parts of Pekko will simply > fail > > to work on some JDK's. While it is possible to inspect the final build > > without Docker, due to the fact that Pekko's build is reproducible the > > easiest way to confirm that the build is correct is by building Pekko via > > the docker image on a system and then confirming that the final jar's are > > the same as what the release manager is providing. > > > > While this may not be ideal, there also isn't any way around it at least > if > > you want to correctly build Pekko. Pekko is not a trivial system to build > > and using Docker is far simpler than any alternative (at least that I > know > > of). > > > > On Mon, May 22, 2023 at 2:53 AM Justin Mclean <[email protected]> > > wrote: > > > >> Hi, > >> > >>> The docker image is not a convenience package (this also foesnt make > >> sense > >>> since Pekko is a library), it's for creating a reproducible environment > >> for > >>> making a release. There are other ways to do this such as a VM image > but > >>> docker is the least friction solution. > >> > >> I’m not sure if this is the case, but requiring docker to check the > >> release may be a barrier to getting IPMC votes on your release. > >> > >> Kind Regards, > >> Justin > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* [email protected]
