Thanks Ryan. Most of the most important files in this Sbt Paradox plugin are partially modified versions of files from other projects. The details are in our LICENSE file and in comments within those files. Those files that are mainly based on 3rd party source - the headers have been left intact. This includes most of the Javascript files in this repo.
SearchIndex.scala: the original file had no license header and we haven't made massive changes so I don't think we should add an ASL header - see the comment at [1] I guess some of the build files could have ASL headers but I suppose that we didn't prioritise the build files used for building our web site (which is what this sbt paradox plugin is for). There is an exclusion in the ASF guidelines for web site files [2] - but it is open to interpretation if these files are covered by that. I have created a PR [3] to add some headers to a few more files. I'll look to get it merged when I test it out. [1] https://github.com/apache/incubator-pekko-sbt-paradox/blob/main/plugin/src/main/scala/org/apache/pekko/SearchIndex.scala#L1 [2] https://www.apache.org/legal/src-headers.html#faq-webpages [3] https://github.com/apache/incubator-pekko-sbt-paradox/pull/66 On Fri, 7 Jul 2023 at 17:08, Ryan Skraba <ryan.skr...@aiven.io.invalid> wrote: > > I've validated this RC: sbt-paradox-1.0.0-RC1 at r62831 > - The SHA512 hash is OK. > - The source file is signed correctly. > - The signature 6BA4DA8B1C88A49428A29C3D0C69C1EF41181E13 is found in the > KEYS file, and on at least one keyserver. > - The source file is consistent with the GitHub tag v1.0.0-RC1, which > corresponds to commit > https://github.com/apache/incubator-pekko-sbt-paradox/tree/4003ccdee81abce31a39c337abfcfde0b924bc62 > - Has a LICENSE file and NOTICE files. The LICENSE file starts with the > ASL2 text and shows the MIT license for the source that this artifacts > includes. > - Has a DISCLAIMER file. > - Does not contain any compiled binaries. > - Compiles and tests pass. > - Has one artifact staged at > https://repository.apache.org/content/groups/staging/org/apache/pekko/pekko-sbt-paradox_2.12_1.0/ > > One minor thing I noted: There are a quite a few files that are missing ASF > headers (among the scala PekkoParadoxPlugin.scala and SearchIndex.scala, > but also JavaScript and other resources that could include the headers). > Was this deliberate? IIRC, incubator projects with a DISCLAIMER can > release with _some_ source files missing headers, so I don't believe this > is a blocker. > > +1 (binding) > > Thanks for the release! > > Ryan > > > On Fri, Jul 7, 2023 at 10:23 AM Samuele Resca <samuele.re...@gmail.com> > wrote: > > > Hi, > > > > - Download links are valid > > - Checksums and signatures verified > > - Compilation from source successful > > > > +1 (not a PPMC member). > > > > Samuele > > > > Il giorno ven 7 lug 2023 alle ore 07:34 Greg Methvin <gr...@apache.org> ha > > scritto: > > > > > +1 > > > > > > On Tue, Jul 4, 2023 at 15:47 PJ Fanning <fannin...@apache.org> wrote: > > > > > > > Hello Pekko Community, > > > > > > > > This is a call for a vote to release Apache Pekko(incubating) Sbt > > > > Paradox Plugin version 1.0.0-RC1. > > > > > > > > The discussion thread: > > > > > > > > https://lists.apache.org/thread/jospm8g0mnfv6j1zofskbg0jj6l93l6o > > > > > > > > The release candidate: > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/pekko/sbt-paradox-1.0.0-RC1/ > > > > > > > > This release has been signed with a PGP key available here: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/pekko/KEYS > > > > > > > > Purpose: > > > > > > > > This is a build tool used in Apache Pekko projects to build the web > > > pages. > > > > > > > > Git branch for the release: > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-pekko-sbt-paradox/releases/tag/v1.0.0-RC1 > > > > Git commit ID: 4003ccdee81abce31a39c337abfcfde0b924bc62 > > > > > > > > Please download, verify, and test. > > > > > > > > We have also staged jars in the Apache Nexus Repository. These were > > > > built with the same code > > > > as appears in this Source Release Candidate. We would appreciate if > > > > users could test with these too. > > > > If anyone finds any serious problems with these jars, please also > > > > notify us on this thread. > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > > > > > In sbt, you can add this resolver. > > > > > > > > resolvers += "Apache Pekko Staging" at > > > > "https://repository.apache.org/content/groups/staging"; > > > > > > > > > > > > The VOTE will pass if we have more positive votes than negative votes > > > > and there must be a minimum of 3 approvals from Pekko PPMC members. > > > > Anyone voting in favour of the release, could you please provide a > > > > list of the checks you have done? > > > > The vote will be left open until 23:59 UTC on 7 July 2023. > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > To learn more about Apache Pekko, please see https://pekko.apache.org/ > > > > > > > > Checklist for reference: > > > > > > > > [ ] Download links are valid. > > > > [ ] Checksums and signatures. > > > > [ ] LICENSE/NOTICE files exist > > > > [ ] No unexpected binary files > > > > [ ] All source files have ASF headers > > > > [ ] Can compile from source > > > > > > > > To compile from the source, please refer to: > > > > > > > > > > > > > https://github.com/apache/incubator-pekko-sbt-paradox#building-from-source > > > > > > > > Some notes about verifying downloads can be found at: > > > > > > > > https://pekko.apache.org/download.html#verifying-downloads > > > > > > > > > > > > Here is my +1. > > > > > > > > Thanks, > > > > > > > > PJ Fanning (Apache Pekko PPMC member) > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
