> I don't recall the software grant mentioned in the notice file to have undergone IP clearance. Can you point me to where this was done?
It would have been nice to know that IP clearance was needed at the time when we asked[1] if there was any issue in bringing in external code into pekko-http. If this was known at the time (i.e. before we attempted to merge the code) then the pekko community may have made a different decision as essentially this is now blocking pekko-http from being released. [1]https://lists.apache.org/thread/qx31xljn6bf7rwcd3kbb9btcdvoxmmwy On Wed, Jul 19, 2023 at 5:31 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) from me. Given the large number of issues I may have missed > something. > > I checked: > - incubating in the name > - signatures and hashes are fine > - DISCLAIMER > - LICENSE is possibly missing 3rd party code licenses due to the number of > files with missing headers? Also these 3rd party files files > [26][27][28][29][30][31][32][33][34] > - NOTICE is fine > - These files are missing headers and are of an unknown license > [1][9][10][11][12][13][14][16][17][18][19][20][21][22][23][24] > - These files seem to have incorrect headers [2][3][4][5][6][7][8][15] > - This file (mentioned in license) also has an incorrect header [35] > - No unexpected binary files > > I don't recall the software grant mentioned in the notice file to have > undergone IP clearance. Can you point me to where this was done? > > You might want to consider making this file part of the build process or > downloading it rather than including it in the source release. [25] > > Kind Regards, > Justin > > 1. ./docs/src/main/paradox/assets/js/scrollToFragment.js > 2. > ./http/src/main/boilerplate/org/apache/pekko/http/javadsl/server/JavaPathMatchers.scala.template > 3. > ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/directives/FormFieldDirectivesInstances.scala.template > 4. > ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/directives/ParameterDirectivesInstances.scala.template > 5. > ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/ApplyConverterInstances.scala.template > 6. > ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/ConstructFromTupleInstances.scala.template > 7. > ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/TupleAppendOneInstances.scala.template > 8. > ./http/src/main/boilerplate/org/apache/pekko/http/scaladsl/server/util/TupleFoldInstances.scala.template > 9. ./http-core/src/test/scripts/autobahn-jenkins/step-1-client-tests.sh > 10. ./http-core/src/test/scripts/autobahn-jenkins/step-2-run-sbt-client.sh > 11. > ./http-core/src/test/scripts/autobahn-jenkins/step-3-download-client-test-results.sh > 12. > ./http-core/src/test/scripts/autobahn-jenkins/step-4-stop-client-tests-server.sh > 13. > ./http-core/src/test/scripts/autobahn-jenkins/step-5-server-tests-all.sh > 14. ./http-core/src/test/scripts/autobahn-jenkins/step-6-collect-results.sh > 15. > ./http-scalafix/scalafix-tests/src/test/scala/org/apache/pekko/http/fix/RuleSuite.scala > 16. ./scripts/authors.pl > 17. ./scripts/authors.scala > 18. ./scripts/commits-for-release-notes.sh > 19. ./scripts/convert_tabs_to_spaces.sh > 20. ./scripts/dos_to_unix.sh > 21. ./scripts/find-javadoc-error.pl > 22. ./scripts/release_stats.sh > 23. ./scripts/remove_trailing_whitespace.sh > 24. ./scripts/build/github-tagging.sh > 25. ./http-tests/src/test/extra-libs.zip > 26. > ./http-core/src/main/scala/org/apache/pekko/http/impl/engine/ws/Utf8Decoder.scala > 27. > ./http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/StringBuilding.scala > 28. > ./http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/util/AsciiTreeLayout.scala > 29. > ./http-tests/src/test/java/org/apache/pekko/http/javadsl/marshalling/sse/EventStreamMarshallingTest.java > 30. > ./http-tests/src/test/java/org/apache/pekko/http/javadsl/unmarshalling/sse/EventStreamUnmarshallingTest.java > 31. > ./http-core/src/test/java/org/apache/pekko/http/javadsl/model/sse/ServerSentEventTest.java > 32. > ./http-core/src/main/java/org/apache/pekko/http/javadsl/model/sse/ServerSentEvent.java > 33. > ./http-core/src/main/java/org/apache/pekko/http/javadsl/model/headers/LastEventId.java > 34. > ./http-core/src/main/scala-2.13-/org/apache/pekko/http/ccompat/CompatImpl.scala > 35. > /http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/DateTime.scala > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io
