So I am getting a difference in binary, but only for one project
(pekko-remote). For Scala 2.12

[info] - pekko-remote_2.12-1.0.1.jar: Mismatch: our
249d204724fc4e87d8ad00d00a12583902b3667d569e96bd703712d8815c6457be1f4de883eac7f1d3f7f3e5215cedd873659418531420dbaa2bc02477db2921
did not match their
316e5366cb654e76afc054fc48d18b19784fa1e671e3cd455900aff3ac923867e85e6057755430d8b3b11ef7905b6d4b2f5c1fccb8eea2cee7ab2cb27005ad75

And for Scala 2.13

[info] - pekko-remote_2.13-1.0.1.jar: Mismatch: our
95c34c631ecc11ffd02b9d823977167e72dbe5ebd9127d15e68c7bd0173c79f144f5bd8391f74e1b641f973a62fb3755c7ce0669e04394b5b44d6bca63dc424a
did not match their
8b3bbdf2c962b23f49d493da1bd3f43de7bfe0d7b19399133fd549dc9fb7d3c464258e44d8d15d489f7ca44547cabe35698fde270816f537111e78a2817a8820

This appears to be due to https://github.com/apache/incubator-pekko/pull/492,
I used jardiff, i.e.

jardiff -g ~/github/diff-temp/
~/.ivy2/local/org.apache.pekko/pekko-remote_2.12/1.0.0/jars/pekko-remote_2.12.jar
~/pekko-release-check-jars/pekko-remote_2.12-1.0.1.jar

to compare the directories and there seems to be a difference in the
bytecode being generated and the difference in bytecode is non trivial,
i.e. one version has

public final class org/apache/pekko/remote/transport/PekkoPduProtobufCodec$

where as another has

public final class org/apache/pekko/remote/transport/PekkoPduProtobufCodec$
implements org/apache/pekko/remote/transport/PekkoPduCodec {


On Tue, Jul 25, 2023 at 1:20 AM PJ Fanning <fannin...@apache.org> wrote:

> Hi everyone,
>
> The Pekko 1.0.1-RC1 vote passed on the Incubator general list.
>
> I have prepared the 1.0.1 jars if anyone wants to compare them to the
> 1.0.1-RC1 jars. They were built from the same git commit. The only
> difference is the version number.
>
> I will leave the jars there for at least 24hrs and publish the
> 1.0.1 jars to Maven Central if there are no issues found. We need at
> least one Pekko PPMC member to validate the 1.0.1 jars.
>
> https://repository.apache.org/content/groups/staging/org/apache/pekko/
>
> In sbt, you can add this resolver.
>
> resolvers += "Apache Pekko Staging" at
> "https://repository.apache.org/content/groups/staging";
>
> Regards,
> PJ
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org
> For additional commands, e-mail: dev-h...@pekko.apache.org
>
>

-- 

Matthew de Detrich

*Aiven Deutschland GmbH*

Immanuelkirchstraße 26, 10405 Berlin

Amtsgericht Charlottenburg, HRB 209739 B

Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen

*m:* +491603708037

*w:* aiven.io *e:* matthew.dedetr...@aiven.io

Reply via email to