Thanks Samuele. I raised an issue about that test. https://github.com/apache/incubator-pekko-http/issues/275
On Thu, 27 Jul 2023 at 10:15, Samuele Resca <samuele.re...@gmail.com> wrote: > > Hi, > > Thanks for the release. I performed the following checks: > > - Verified download links are valid. > - Checked the links in the release note. > - Verified checksums and signatures are valid following: > https://pekko.apache.org/download.html#verifying-downloads > - Verified the LICENSE and NOTICE files exist > - Compiled successfully from the source > - No unexpected binaries > - Run sbt test > > Note that, the sbt test step is failing due to the following issue in > FileAndResourceDirectivesSpec: > > - should not follow symbolic links to find a file *** FAILED *** (111 > milliseconds) > > [info] true was not equal to false > (FileAndResourceDirectivesSpec.scala:216) > > I reproduced it on my local machine and on a completely new devbox. It > seems that the test fail only when I run it on the extracted source: > apache-pekko-http-1.0.0-incubating-src-20230726.tgz. > The extracted src files don't contain the symbolic link used for the > purpose of the test > (/workspaces/apache-pekko-http-1.0.0-incubating-src-20230726/http-tests/src/test/resources/dirWithLink). > I tried multiple tar options for preserving the symlinks in the extraction > phase, but I wasn't able to find one. > > I don't think this is blocking the release as it is not an implementation > issue, but I wanted to point it out. > > +1 (not a PPMC member). > > Thanks, > Samuele > > Il giorno gio 27 lug 2023 alle ore 02:59 Justin Mclean < > jus...@classsoftware.com> ha scritto: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signatures and hashes are fine > > - LICENSE and NOTICE are good > > - files have correct headers > > - no unexpected binary files > > - can compile from source > > > > Kind Regards, > > Justin > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
