Hi Justin, The Eclipse license was added in https://github.com/apache/incubator-pekko-connectors/pull/214
The idea was that the Akka code had a comment saying that some code in RequestState.scala was inspired by some Paho code. The code is dual licensed. Eclipse Distribution License and Eclipse Public License. We want to use the code under the more permissive Eclipse Distribution License. EDL is Category A. Is this ok? We can do an RC2 where we fix up the missing source headers. So far, I'm not having issues with building from source but we can add some instructions. Regards, PJ On Mon, 30 Oct 2023 at 17:23, PJ Fanning <fannin...@gmail.com> wrote: > > Thanks Justin. I will cancel this vote and look into the issue that > you've raised. > > On Mon, 30 Oct 2023 at 16:49, Justin Mclean <jus...@classsoftware.com> wrote: > > > > HI, > > > > > > Sorry, but it’s -1 (binding) from me. The source contains code under the > > EPL license, a category B license that can’t be included in a source > > release. [6] Perhaps [4] and [5] are also under this license? > > > > I checked: > > - incubating in the name > > - hash and signature are fine > > - LICENSE and NOTICE are fine. However, it would be nice to note the > > copyright owner. > > - No binary files > > - Some files are midding headers [1][2][3][4] > > - Can't compile - no obvious instructions are included, and the compile > > fails with "Failed to derive version from git tags”. > > > > Kind Regards, > > Justin > > > > 1. > > ./csv-bench/src/main/scala/org/apache/pekko/stream/connectors/csv/scaladsl/CsvBench.scala > > 2. > > ./google-cloud-bigquery/src/main/boilerplate/org/apache/pekko/stream/connectors/googlecloud/bigquery/scaladsl/schema/ProductSchemasInstances.scala.template > > 3. > > ./google-cloud-bigquery/src/main/boilerplate/org/apache/pekko/stream/connectors/googlecloud/bigquery/scaladsl/spray/BigQueryProductFormatsInstances.scala.template > > 4. > > ./mqtt-streaming-bench/src/main/scala/org/apache/pekko/stream/connectors/mqtt/MqttPerf.scala > > 5. > > ./mqtt-streaming-bench/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/MqttPerf.scala > > 6. > > ./mqtt-streaming/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/impl/RequestState.scala > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
