On Mon, Feb 5, 2024 at 1:52 AM Matthew de Detrich <matthew.dedetr...@aiven.io.invalid> wrote:
> So now that Pekko Connectors is at 1.1.x I think it's time to revive the > discussion for integrating aws-spi-pekko-http within Pekko Connectors > itself. > In general, I think it shouldn't be a goal to include 'everything' into Pekko Connectors - having an active ecosystem of connectors outside of Apache Pekko itself would be a sign of health, and we should only have connectors in the projects that we're prepared to maintain long-term. Also, now that the first Pekko releases are out, the 'bootstrapping' problems might be less urgent because of compatibility. That said... > it makes sense to include aws-spi-pekko-http[1] within > pekko itself because its critical dependency to build many projects within > pekko connectors (AwsLambda, DynamoDb, EventBridge, Kinesis, Sns, Sqs) and > it also has no real use outside of pekko-connectors considering its an SPI > between AWS SDK and akka/pekko http This seems like a strong reason to indeed pull the functionality provided by aws-spi-pekko-http into Pekko Connectors. Kind regards, Arnout , i.e. same deal with akka-http-cors > (which is now official part of Pekko Http). Given critical time constraints > at the time it made sense to fork aws-spi-akka-http into aws-spi-pekko-http > but seeing as we are now working on Pekko Connectors 1.1.x now is the > perfect opportunity to revisit this. > > Another thing to note is that due to > https://github.com/pjfanning/aws-spi-pekko-http not being contained within > Pekko Connectors we had to duplicate code that exposes implementation > details[2] which would ordinarily not be required if contained within the > pekko-connectors repository. > > Some of the obvious questions apply i.e. shall we do this officially like > we did with akka-http-cors i.e. create an SGA and reach out to the official > author? Another thing to note is that the project itself is not that big, > i.e. the entire implementation is 3 files[3] with the largest one being > ~200 lines long and the sources appear to be predominantly written by a > single author so if we go ahead with an SGA, if accepted by the author the > licensing/code origin should be quite trivial. > > 1: https://github.com/pjfanning/aws-spi-pekko-http > 2: > > https://github.com/pjfanning/aws-spi-pekko-http/tree/main/src/main/scala-2.12/com/github/pjfanning/pekkohttpspi > , > > https://github.com/pjfanning/aws-spi-pekko-http/tree/main/src/main/scala-2.13/com/github/pjfanning/pekkohttpspi > and > > https://github.com/pjfanning/aws-spi-pekko-http/tree/main/src/main/scala-3/com/github/pjfanning/pekkohttpspi > 3: > > https://github.com/pjfanning/aws-spi-pekko-http/tree/main/src/main/scala/com/github/pjfanning/pekkohttpspi > > On Sun, Jun 25, 2023 at 7:06 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > Regarding ICLAs for software grants, it may depend on how the software is > > licensed. It is nice to have an ICLA for every major contributor, and if > > the software was under an OS license, then it is needed. However, in this > > case, it’s under ALv2, so ICLAs are just nice to have but not required. > > > > Kind Regards, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Alexanderufer 3-7, 10117 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > -- Arnout Engelen ASF Security Response Committer on Apache Pekko Committer on NixOS Independent Open Source consultant
