I don't know much about the Pekko Persistence implementations. Is the 'revision' support something that we should try to fix for 1.1.0 and if so, is it important enough for 1.1.0-M1?
https://github.com/apache/incubator-pekko-persistence-jdbc/issues/30 On Mon, 11 Mar 2024 at 12:37, Matthew de Detrich <matthew.dedetr...@aiven.io.invalid> wrote: > > Just pointing out that we are having a discussion regarding Scala 3/Slick > 3.5.0 support > in pekko-projection-slick that adds another argument for releasing a M1 of > pekko-persistence-jdbc > at > https://github.com/apache/incubator-pekko-projection/issues/110#issuecomment-1988228503 > > On Sun, Mar 10, 2024 at 11:06 AM Matthew de Detrich < > matthew.dedetr...@aiven.io> wrote: > > > > I would prefer not to release while it is using a snapshot version of > > our paradox plugin. Let's get the release completed for the paradox > > plugin first. > > > > Okay sure, lets wait for that > > > > On Sun, Mar 10, 2024 at 11:05 AM PJ Fanning <fannin...@apache.org> wrote: > > > >> I would prefer not to release while it is using a snapshot version of > >> our paradox plugin. Let's get the release completed for the paradox > >> plugin first. > >> > >> On Sun, 10 Mar 2024 at 11:03, Matthew de Detrich > >> <matthew.dedetr...@aiven.io.invalid> wrote: > >> > > >> > With all of the PR's from Scala Steward merged, I would advocate for an > >> M1 > >> > release tomorrow > >> > unless there is a strong objection otherwise. > >> > > >> > Not going to rehash in details the reasons why for an M1 rather than a > >> full > >> > release, but we have another > >> > driver mssql which also may require breaking changes in the future[1] > >> ontop > >> > of oracle[2] and since > >> > I would like to ideally make postgres-persistence-jdbc SemVer > >> compatible it > >> > makes sense to make > >> > the M1 release now, also to be fair to people waiting for Slick 3.5.x > >> > support. > >> > > >> > Hopefully with an M1 release, more people will actually use > >> > pekko-persistence-jdbc so that we can > >> > get some contributions for the oracle/mssql drivers. > >> > > >> > On Thu, Mar 7, 2024 at 4:27 PM Matthew de Detrich < > >> > matthew.dedetr...@aiven.io> wrote: > >> > > >> > > > pekko-persistence-jdbc is not downloaded very often from Maven > >> > > Central. I doubt whether us releasing a milestone release will help > >> > > Slick testing much. > >> > > > >> > > Well that can also be because for a lot of users the current > >> > > pekko-persistence-jdbc wasn't really usable outside of migrating > >> > > from akka to pekko because it was stuck on a really old version of > >> Slick > >> > > (3.3.x). > >> > > > >> > > In other words if anything the current low download rate from Maven > >> central > >> > > can be indicating that in fact users were in fact waiting for an RC > >> style > >> > > of release > >> > > to test/use Slick 3.5.x and there definitely was multiple people in > >> the > >> > > community asking > >> > > for it (even in the PR itself[1]!) > >> > > > >> > > > Regarding Oracle testing, it would be good to work out what is going > >> > > on with that strange region error. If we have any Oracle experts, it > >> > > it would be great to get this sorted out. > >> > > > >> > > Agreed, and from the sounds of the PR it may break the API? If so, > >> hence > >> > > another reason for an M1 now in case this may happen. > >> > > > >> > > 1: > >> > > > >> https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#pullrequestreview-1521620887 > >> > > > >> > > On Thu, Mar 7, 2024 at 4:20 PM PJ Fanning <fannin...@gmail.com> > >> wrote: > >> > > > >> > >> pekko-persistence-jdbc is not downloaded very often from Maven > >> > >> Central. I doubt whether us releasing a milestone release will help > >> > >> Slick testing much. > >> > >> > >> > >> Regarding Oracle testing, it would be good to work out what is going > >> > >> on with that strange region error. If we have any Oracle experts, it > >> > >> would be great to get this sorted out. > >> > >> > >> > >> On Thu, 7 Mar 2024 at 16:03, Matthew de Detrich > >> > >> <matthew.dedetr...@aiven.io.invalid> wrote: > >> > >> > > >> > >> > > I would favour just making a full 1.1.0 release. I don't see the > >> > >> > benefit of having a milestone release. > >> > >> > > >> > >> > It was requested for us to do an RC so the community could > >> properly test > >> > >> > Slick 3.5.0-RC5 but we didn't do this because we want our projects > >> to > >> > >> > always be in a releasable state[1] and hence I suspect that no one > >> > >> really > >> > >> > tested > >> > >> > pekko-persistence-jdbc because it wasn't really announced > >> anywhere. The > >> > >> > changes from Slick 3.3.x to 3.5.0 were extremely extensive so I > >> think > >> > >> it's > >> > >> > warranted > >> > >> > to be more prudent here. > >> > >> > > >> > >> > Also we need to make sure that the project works properly with > >> > >> pekko-core > >> > >> > 1.1.x > >> > >> > along with all of the inlining and other changes and pekko-core > >> 1.1.x > >> > >> hasn't > >> > >> > even been released yet. > >> > >> > > >> > >> > Support for the latest oracle[2] is also something that we may > >> want to > >> > >> add > >> > >> > after M1, > >> > >> > this seems to be undecided? > >> > >> > > >> > >> > 1: > >> > >> > >> https://github.com/slick/slick/discussions/2891#discussioncomment-8550269 > >> > >> > 2: > >> https://github.com/apache/incubator-pekko-persistence-jdbc/pull/115 > >> > >> > > >> > >> > On Thu, Mar 7, 2024 at 3:53 PM PJ Fanning <fannin...@gmail.com> > >> wrote: > >> > >> > > >> > >> > > I would favour just making a full 1.1.0 release. I don't see the > >> > >> > > benefit of having a milestone release. > >> > >> > > > >> > >> > > On Thu, 7 Mar 2024 at 15:14, Matthew de Detrich > >> > >> > > <matthew.dedetr...@aiven.io.invalid> wrote: > >> > >> > > > > >> > >> > > > Now that Scala 3 support has been merged with the release of > >> > >> > > > Slick 3.5.0[1] I think it's a good time to make a M1 release > >> given > >> > >> that > >> > >> > > > the changes in Slick 3.5.0 were so extensive, just to make sure > >> > >> > > everything > >> > >> > > > is working as intended and a milestone release should signal > >> to the > >> > >> > > > community to "please use it to test it". > >> > >> > > > > >> > >> > > > Since scala steward support is merged[2] doing the milestone > >> when > >> > >> > > > the update PR's are created early next week seems like a good > >> > >> candidate > >> > >> > > > in terms of time. There also is a question of whether we > >> should also > >> > >> > > > fix the issue with the latest oracle version[2] for the M1. > >> > >> > > > > >> > >> > > > Thoughts? > >> > >> > > > > >> > >> > > > 1: > >> > >> https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44 > >> > >> > > > 2: > >> > >> https://github.com/apache/incubator-pekko-persistence-jdbc/pull/123 > >> > >> > > > 3: > >> > >> https://github.com/apache/incubator-pekko-persistence-jdbc/pull/115 > >> > >> > > > > >> > >> > > > -- > >> > >> > > > > >> > >> > > > Matthew de Detrich > >> > >> > > > > >> > >> > > > *Aiven Deutschland GmbH* > >> > >> > > > > >> > >> > > > Immanuelkirchstraße 26, 10405 Berlin > >> > >> > > > > >> > >> > > > Alexanderufer 3-7, 10117 Berlin > >> > >> > > > > >> > >> > > > Amtsgericht Charlottenburg, HRB 209739 B > >> > >> > > > > >> > >> > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > >> > >> > > > > >> > >> > > > *m:* +491603708037 > >> > >> > > > > >> > >> > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > >> > >> > > > >> > >> > > > >> --------------------------------------------------------------------- > >> > >> > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > >> > >> > > For additional commands, e-mail: dev-h...@pekko.apache.org > >> > >> > > > >> > >> > > > >> > >> > > >> > >> > -- > >> > >> > > >> > >> > Matthew de Detrich > >> > >> > > >> > >> > *Aiven Deutschland GmbH* > >> > >> > > >> > >> > Immanuelkirchstraße 26, 10405 Berlin > >> > >> > > >> > >> > Alexanderufer 3-7, 10117 Berlin > >> > >> > > >> > >> > Amtsgericht Charlottenburg, HRB 209739 B > >> > >> > > >> > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > >> > >> > > >> > >> > *m:* +491603708037 > >> > >> > > >> > >> > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > >> > >> > >> > >> --------------------------------------------------------------------- > >> > >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > >> > >> For additional commands, e-mail: dev-h...@pekko.apache.org > >> > >> > >> > >> > >> > > > >> > > -- > >> > > > >> > > Matthew de Detrich > >> > > > >> > > *Aiven Deutschland GmbH* > >> > > > >> > > Immanuelkirchstraße 26, 10405 Berlin > >> > > > >> > > Alexanderufer 3-7, 10117 Berlin > >> > > > >> > > Amtsgericht Charlottenburg, HRB 209739 B > >> > > > >> > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > >> > > > >> > > *m:* +491603708037 > >> > > > >> > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > >> > > > >> > > >> > > >> > -- > >> > > >> > Matthew de Detrich > >> > > >> > *Aiven Deutschland GmbH* > >> > > >> > Immanuelkirchstraße 26, 10405 Berlin > >> > > >> > Alexanderufer 3-7, 10117 Berlin > >> > > >> > Amtsgericht Charlottenburg, HRB 209739 B > >> > > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > >> > > >> > *m:* +491603708037 > >> > > >> > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > >> For additional commands, e-mail: dev-h...@pekko.apache.org > >> > >> > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Alexanderufer 3-7, 10117 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > > > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Alexanderufer 3-7, 10117 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
