I think we can proceed with this RC. I did some digging into the test failures and put my summary here:
https://github.com/apache/pekko-http/pull/548#issuecomment-2105189392 In short, the revert in PR 550 fixes pekko-http and we can consider later whether to reapply the change with the workaround described that I added to PR 548. On 2024/05/10 14:23:44 PJ Fanning wrote: > I'll reopen the vote because I found the cause of the issue [1]. > I would still like to try to debug why the pekko-http PR [2] is causing > issues. It could still be an issue in the new ByteString asInputStream > function. > > I would still appreciate if people review the RC with the proviso that we may > still need to fix ByteString asInputStream function. > > [1] https://github.com/apache/pekko-http/issues/549 > [2] https://github.com/apache/pekko-http/pull/550 > > On 2024/05/10 12:01:26 PJ Fanning wrote: > > I'm going to cancel this vote due to > > https://github.com/apache/pekko-http/issues/549 > > > > On 2024/05/08 12:05:27 PJ Fanning wrote: > > > Hello Pekko Community, > > > > > > This is a call for a vote to release Apache Pekko version 1.1.0-M1-RC1. > > > > > > The discussion thread: > > > > > > https://lists.apache.org/thread/mc36onpb4nhn975gd3rtglvrpf6g4k4d > > > > > > The release candidate: > > > > > > https://dist.apache.org/repos/dist/dev/pekko/1.1.0-M1-RC1/ > > > > > > This release has been signed with a PGP key available here: > > > > > > https://downloads.apache.org/pekko/KEYS > > > > > > Release Notes: > > > > > > https://github.com/apache/pekko/pull/1204/files > > > > > > Git tag for the release: > > > > > > https://github.com/apache/incubator-pekko/tree/v1.1.0-M1-RC1 > > > Git commit ID: b34d529f344f50801b4dd9f4df966b03d3464c2f > > > > > > Please download, verify, and test. > > > > > > We have also staged jars in the Apache Nexus Repository. These were built > > > with the same code as appears in this Source Release Candidate. > > > We would appreciate if users could test with these too. > > > If anyone finds any serious problems with these jars, please also notify > > > us > > > on this thread. > > > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > > > For sbt 1.9.4 or greater you can add this resolver > > > > > > resolvers += Resolver.ApacheMavenStagingRepo > > > > > > Otherwise for older versions of sbt > > > > > > resolvers += "Apache Pekko Staging" at " > > > https://repository.apache.org/content/groups/staging"; > > > > > > > > > The VOTE will pass if we have more positive votes than negative votes > > > and there must be a minimum of 3 approvals from Pekko PMC members. > > > Anyone voting in favour of the release, could you please provide a list of > > > the checks you have done? > > > The vote will be left open for at least 72hrs. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > To learn more about Apache Pekko, please see https://pekko.apache.org/ > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > [ ] Checksums and signatures. > > > [ ] LICENSE/NOTICE files exist > > > [ ] No unexpected binary files > > > [ ] All source files have ASF headers > > > [ ] Can compile from source > > > [ ] Can verify the binary build > > > > > > To compile from the source, please refer to: > > > > > > https://github.com/apache/incubator-pekko/blob/main/README.md#building-from-source > > > > > > To verify the binary build, please refer to: > > > > > > https://github.com/apache/incubator-pekko/blob/main/README.md#verifying-the-binary-build > > > > > > Some notes about verifying downloads can be found at: > > > > > > https://pekko.apache.org/download.html#verifying-downloads > > > > > > Here is my +1 (binding). > > > > > > Thanks, > > > PJ Fanning (Apache Pekko PMC member) > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
