Hi, +1 from me. Below the checks I made:
[X] Download links are valid [X] Checksums and signatures [X] LICENSE/NOTICE files exist [X] No unexpected binary files [X] Can compile from source [X] Can verify the binary build [X] Tests are running locally Thanks in advance. Samuele > On 29 May 2024, at 18:45, kerr <hepin1...@gmail.com> wrote: > > I compiled ,header checked it locally, when try to run all the tests of it. > > Two tests stacked on Windows 11 and Java 21. > | => org.apache.pekko.grpc.scaladsl.GrpcExceptionHandlerSpec 154s > | => org.apache.pekko.grpc.internal.GrpcProtocolWebTextSpec 154s > > The binary build works with simple demo. > > +1 if these two tests passed on your locally too. > > > [ x] Download links are valid. > [ x] Checksums and signatures. > [ x] LICENSE/NOTICE files exist > [ x] No unexpected binary files > [ x] All source files have ASF headers > [x ] Can compile from source > [x ] Can verify the binary build > 何品 > > > JingZhang Chen <iroio...@gmail.com> 于2024年5月30日周四 01:07写道： > >> +1 for me. it was verified in Apple m1. >> >> - git commit id & tag correct >> - compile no complaint >> - binary build verified by using `pekko-sample-cluster-client-grpc-scala` >> - don't know why the test was complaint unsuccessful. >> ------ >> [success] Total time: 136 s (02:16), completed >> [success] Total time: 24 s, completed 2024-5-30 0:54:13 >> ------ >> [info] Run completed in 1 minute, 20 seconds. >> [info] Total number of tests run: 251 >> [info] Suites: completed 31, aborted 0 >> [info] Tests: succeeded 251, failed 0, canceled 1, ignored 0, pending 80 >> [info] All tests passed. >> [error] (runtime / Test / test) sbt.TestsFailedException: Tests >> unsuccessful >> >> >> [x] Download links are valid. >> [x] Checksums and signatures. >> [x] LICENSE/NOTICE files exist >> [x] No unexpected binary files >> [ ] All source files have ASF headers >> [x] Can compile from source >> [x] Can verify the binary build >> >> laglangyue <laglan...@foxmail.com> 于2024年5月29日周三 21:10写道： >> >>> +1, I do some checks, download, shasum, gpg, compile and >>> test command on Apple m2, sbt 1.9.9 , jdk 11 >>> >>> >>> [x] Download links are valid. >>> [x] Checksums and signatures. >>> [x] Can compile from source >>> [x] Can verify the binary build >>> >>> >>> >>> >>> laglangyue >>> laglan...@foxmail.com >>> >>> >>> >>> >>> >>> >>> >>> >>> ------------------ Original ------------------ >>> From: >>> "dev" >>> < >>> fannin...@apache.org>; >>> Date: Wed, May 29, 2024 06:56 PM >>> To: "dev"<dev@pekko.apache.org>; >>> >>> Subject: [VOTE] Release Apache Pekko gRPC 1.1.0-M1-RC1 >>> >>> >>> >>> Hello Pekko Community, >>> >>> This is a call for a vote to release Apache Pekko gRPC version >>> 1.1.0-M1-RC1. >>> >>> The discussion thread: >>> >>> https://lists.apache.org/thread/d9zfmpkn5fdgzv3tl8fcqdgx3hcg06ls >>> >>> The release candidate: >>> >>> https://dist.apache.org/repos/dist/dev/pekko/GRPC-1.1.0-M1-RC1/ >>> >>> This release has been signed with a PGP key available here: >>> >>> https://downloads.apache.org/pekko/KEYS >>> >>> Release Notes: >>> >>> https://github.com/apache/pekko-grpc/pull/316/files >>> >>> Git tag for the release: >>> >>> https://github.com/apache/pekko-grpc/tree/v1.1.0-M1-RC1 >>> Git commit ID: c26abf152908a7902a67cfc7b42f5903e7824e94 >>> >>> Please download, verify, and test. >>> >>> I have also staged jars in the Apache Nexus Repository. These were built >>> with the same code as appears in this Source Release Candidate. >>> I would appreciate if users could test with these too. >>> If anyone finds any serious problems with these jars, please also notify >> us >>> on this thread. >>> >>> https://repository.apache.org/content/groups/staging/org/apache/pekko/ >>> >>> For sbt 1.9.4 or greater you can add this resolver >>> >>> resolvers += Resolver.ApacheMavenStagingRepo >>> >>> Otherwise for older versions of sbt >>> >>> resolvers += "Apache Pekko Staging" at " >>> https://repository.apache.org/content/groups/staging"; >>> >>> >>> The VOTE will pass if we have more positive votes than negative votes >>> and there must be a minimum of 3 approvals from Pekko PMC members. >>> Anyone voting in favour of the release, could you please provide a list >> of >>> the checks you have done? >>> The vote will be left open for at least 72hrs. >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> To learn more about Apache Pekko, please see https://pekko.apache.org/ >>> >>> Checklist for reference: >>> >>> [ ] Download links are valid. >>> [ ] Checksums and signatures. >>> [ ] LICENSE/NOTICE files exist >>> [ ] No unexpected binary files >>> [ ] All source files have ASF headers >>> [ ] Can compile from source >>> [ ] Can verify the binary build >>> >>> To compile from the source, please refer to: >>> >>> >>> >> https://github.com/apache/pekko-grpc/blob/main/README.md#building-from-source >>> >>> To verify the binary build, please refer to: >>> >>> >>> >> https://github.com/apache/pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build >>> >>> Some notes about verifying downloads can be found at: >>> >>> https://pekko.apache.org/download.html#verifying-downloads >>> >>> Here is my +1 (binding). >>> >>> Thanks, >>> PJ Fanning (Apache Pekko PMC member) >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org >>> For additional commands, e-mail: dev-h...@pekko.apache.org >> >> >> >> -- >> Best regards >> >> Jingzhang Chen(Roiocam) >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
