The PR is approved. https://github.com/apache/pekko-persistence-jdbc/pull/202
I guess it would be tidier to cancel this vote and do an RC2 with this change. On Mon, 3 Jun 2024 at 03:02, Jingzhang Chen <iroio...@gmail.com> wrote: > > I create a ticket for it: > https://github.com/apache/pekko-persistence-jdbc/issues/201 > > Jingzhang Chen <iroio...@gmail.com> 于2024年6月3日周一 09:40写道： > > > > > I encountered an error in startup, which seems to be caused by the upgrade > > of slick.: https://github.com/slick/slick/issues/2933 > > > > > > Caused by: java.lang.NoClassDefFoundError: scala/reflect/api/Trees$TreeApi > > at > > slick.lifted.AnyOptionExtensionMethods$.getOrElse$extension(ExtensionMethods.scala:219) > > at > > org.apache.pekko.persistence.jdbc.query.dao.ReadJournalQueries.<init>(ReadJournalQueries.scala:33) > > at > > org.apache.pekko.persistence.jdbc.query.dao.DefaultReadJournalDao.<init>(DefaultReadJournalDao.scala:42) > > at > > java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native > > Method) > > at > > java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > > at > > java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > > at > > java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) > > at > > org.apache.pekko.actor.ReflectiveDynamicAccess.$anonfun$createInstanceFor$1(ReflectiveDynamicAccess.scala:50) > > > > > > > > [x] Download links are valid. > > [x] Checksums and signatures. > > [x] LICENSE/NOTICE files exist > > [x] No unexpected binary files > > [x] All source files have ASF headers > > [x] Can compile from source > > [ ] Can verify the binary build > > > > laglangyue <laglan...@foxmail.com> 于2024年5月31日周五 21:46写道： > > > >> +1，I downloaded，compiled and tested with m2-cpu，jdk11 > >> > >> > >> > >> > >> > >> 发自我的iPhone > >> > >> > >> ------------------ Original ------------------ > >> From: Samuele Resca <samuele.re...@gmail.com> > >> Date: Fri,May 31,2024 5:28 AM > >> To: laglanyue <laglan...@foxmail.com> > >> Subject: Re: [VOTE] Release Apache Pekko Persistence JDBC 1.1.0-M1-RC1 > >> > >> > >> > >> Hi, > >> > >> +1 from me. > >> > >> I performed the following checks: > >> > >> [X] Download links are valid > >> [X] Checksums and signatures > >> [X] LICENSE/NOTICE files exist > >> [X] Can compile from source > >> [X] No unexpected binary files > >> [X] Can verify the binary build > >> [X] Tests are running locally > >> > >> Samuele > >> > >> > On 30 May 2024, at 13:01, kerr wrote: > >> > > >> > I will check this when back home. > >> > 何品 > >> > > >> > > >> > PJ Fanning 于2024年5月30日周四 19:57写道： > >> > > >> >> Hello Pekko Community, > >> >> > >> >> This is a call for a vote to release Apache Pekko Persistence > >> JDBC > >> >> version 1.1.0-M1-RC1. > >> >> > >> >> The discussion thread: > >> >> > >> >> https://lists.apache.org/thread/95sjkpbdomwbbhvw1os9g0ol2f6rt32b > >> >> > >> <https://lists.apache.org/thread/95sjkpbdomwbbhvw1os9g0ol2f6rt32b>>>; > >> > >> >> The release candidate: > >> >> > >> >> > >> https://dist.apache.org/repos/dist/dev/pekko/PERSISTENCE-JDBC-1.1.0-M1-RC1/ > >> >> > >> <https://dist.apache.org/repos/dist/dev/pekko/PERSISTENCE-JDBC-1.1.0-M1-RC1/>>>; > >> > >> >> This release has been signed with a PGP key available here: > >> >> > >> >> https://downloads.apache.org/pekko/KEYS > >> >> > >> >> Release Notes: > >> >> > >> >> https://github.com/apache/pekko-persistence-jdbc/pull/197/files > >> >> > >> <https://github.com/apache/pekko-persistence-jdbc/pull/197/files>>>; > >> > >> >> Git tag for the release: > >> >> > >> >> > >> https://github.com/apache/pekko-persistence-jdbc/tree/v1.1.0-M1-RC1 > >> >> > >> <https://github.com/apache/pekko-persistence-jdbc/tree/v1.1.0-M1-RC1>>>; > >> Git commit ID: 0d0a85d2fc46a3b7d75a3613db13e7065fae83fb > >> >> > >> >> Please download, verify, and test. > >> >> > >> >> I have also staged jars in the Apache Nexus Repository. These > >> were built > >> >> with the same code as appears in this Source Release Candidate. > >> >> I would appreciate if users could test with these too. > >> >> If anyone finds any serious problems with these jars, please > >> also notify us > >> >> on this thread. > >> >> > >> >> > >> https://repository.apache.org/content/groups/staging/org/apache/pekko/ > >> >> > >> <https://repository.apache.org/content/groups/staging/org/apache/pekko/>>>; > >> > >> >> For sbt 1.9.4 or greater you can add this resolver > >> >> > >> >> resolvers += Resolver.ApacheMavenStagingRepo > >> >> > >> >> Otherwise for older versions of sbt > >> >> > >> >> resolvers += "Apache Pekko Staging" at " > >> >> https://repository.apache.org/content/groups/staging"; > >> >> > >> >> > >> >> The VOTE will pass if we have more positive votes than negative > >> votes > >> >> and there must be a minimum of 3 approvals from Pekko PMC > >> members. > >> >> Anyone voting in favour of the release, could you please provide > >> a list of > >> >> the checks you have done? > >> >> The vote will be left open for at least 72hrs. > >> >> > >> >> [ ] +1 approve > >> >> [ ] +0 no opinion > >> >> [ ] -1 disapprove with the reason > >> >> > >> >> To learn more about Apache Pekko, please see > >> https://pekko.apache.org/ > >> >> <https://pekko.apache.org/>>>; > >> >> Checklist for reference: > >> >> > >> >> [ ] Download links are valid. > >> >> [ ] Checksums and signatures. > >> >> [ ] LICENSE/NOTICE files exist > >> >> [ ] No unexpected binary files > >> >> [ ] All source files have ASF headers > >> >> [ ] Can compile from source > >> >> [ ] Can verify the binary build > >> >> > >> >> To compile from the source, please refer to: > >> >> > >> >> > >> https://github.com/apache/pekko/blob/main/README.md#building-from-source > >> >> > >> <https://github.com/apache/pekko/blob/main/README.md#building-from-source>>>; > >> > >> >> This refers to the main Pekko. The main diff for Pekko > >> Persistence > >> >> JDBC is that Java 8 is preferred for building. > >> >> > >> >> To verify the binary build, please refer to: > >> >> > >> >> > >> >> > >> https://github.com/apache/pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build > >> >> > >> <https://github.com/apache/pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build>>>; > >> > >> >> Some notes about verifying downloads can be found at: > >> >> > >> >> https://pekko.apache.org/download.html#verifying-downloads > >> >> > >> <https://pekko.apache.org/download.html#verifying-downloads>>>; > >> >> Here is my +1 (binding). > >> >> > >> >> Thanks, > >> >> PJ Fanning (Apache Pekko PMC member) > >> >> > >> >> > >> --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > >> >> For additional commands, e-mail: dev-h...@pekko.apache.org > >> >> > >> >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > >> For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > -- > > Best regards > > > > Jingzhang Chen(Roiocam) > > > > > -- > Best regards > > Jingzhang Chen(Roiocam) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
