Thanks Nicolas and JingZhang for reviewing this. We have run into issues with the reproducible build tool in the past where the time zone of the build machine affects the jar contents. Maybe that is what is happening here. The jardiff looks correct though - just the version number is different between the 1.1.0-M1-RC1 and 1.1.0-M1 jars. The v1.1.0-M1 git tag is on the same commit as the v1.1.0-M1-RC2 git tag. Apologies for the mistake in my email of yesterday where I mistakenly referenced v1.1.0-M1-RC1. I will proceed with the release of the 1.1.0-M1 jars.
On Tue, 11 Jun 2024 at 08:37, JingZhang Chen <roio...@apache.org> wrote: > > Apologies for any delays, I've just returned to the office from my vacation. > > > One approach is to check if the build is reproducible from the git tag > (v1.1.0-M1). > > I think the m1 should be a release from 1.1.0-m1-rc2? > > This is my +1, I have been verify it below: > > ---------- > Verifying that the download link is correct: [pekko-persistence-jdbc, 3, > -sources.jar] > Verifying that the jars is matching... > > diff --git a/META-INF/MANIFEST.MF b/META-INF/MANIFEST.MF > index 5f0bfeb..d30e4c2 100644 > --- a/META-INF/MANIFEST.MF > +++ b/META-INF/MANIFEST.MF > @@ -1,5 +1,5 @@ > Manifest-Version: 1.0 > Specification-Vendor: Apache Software Foundation > Specification-Title: pekko-persistence-jdbc > -Specification-Version: 1.1.0-M1-RC2 > +Specification-Version: 1.1.0-M1 > > > ---------- > Verifying that the download link is correct: [pekko-persistence-jdbc, 3, > .jar] > Verifying that the jars is matching... > > diff --git a/META-INF/MANIFEST.MF b/META-INF/MANIFEST.MF > index 8014251..66005e8 100644 > --- a/META-INF/MANIFEST.MF > +++ b/META-INF/MANIFEST.MF > @@ -4,8 +4,8 @@ > bc/current/ > Implementation-Vendor-Id: org.apache.pekko > Implementation-Vendor: Apache Software Foundation > -Implementation-Version: 1.1.0-M1-RC2 > +Implementation-Version: 1.1.0-M1 > Specification-Title: pekko-persistence-jdbc > Specification-Vendor: Apache Software Foundation > -Specification-Version: 1.1.0-M1-RC2 > +Specification-Version: 1.1.0-M1 > > > ---------- > Verifying that the download link is correct: pekko-persistence-jdbc 3 > Verifying that the jars is matching... > > diff --git a/META-INF/MANIFEST.MF b/META-INF/MANIFEST.MF > index 8014251..66005e8 100644 > --- a/META-INF/MANIFEST.MF > +++ b/META-INF/MANIFEST.MF > @@ -4,8 +4,8 @@ > bc/current/ > Implementation-Vendor-Id: org.apache.pekko > Implementation-Vendor: Apache Software Foundation > -Implementation-Version: 1.1.0-M1-RC2 > +Implementation-Version: 1.1.0-M1 > Specification-Title: pekko-persistence-jdbc > Specification-Vendor: Apache Software Foundation > -Specification-Version: 1.1.0-M1-RC2 > +Specification-Version: 1.1.0-M1 > > > ---------- > All Release verified! > ~/runtime 1m 51s > > > 15:35:17 > ❯ ls -lr downloads > total 42360 > -rw-r--r--@ 1 roiocam staff 784101 6 11 15:35 > pekko-persistence-jdbc_3-1.1.0-M1.jar > -rw-r--r--@ 1 roiocam staff 108779 6 11 15:34 > pekko-persistence-jdbc_3-1.1.0-M1-sources.jar > -rw-r--r--@ 1 roiocam staff 3524123 6 11 15:34 > pekko-persistence-jdbc_3-1.1.0-M1-javadoc.jar > -rw-r--r--@ 1 roiocam staff 784106 6 11 15:35 > pekko-persistence-jdbc_3-1.1.0-M1-RC2.jar > -rw-r--r--@ 1 roiocam staff 108783 6 11 15:34 > pekko-persistence-jdbc_3-1.1.0-M1-RC2-sources.jar > -rw-r--r--@ 1 roiocam staff 3524729 6 11 15:34 > pekko-persistence-jdbc_3-1.1.0-M1-RC2-javadoc.jar > -rw-r--r--@ 1 roiocam staff 574976 6 11 15:34 > pekko-persistence-jdbc_2.13-1.1.0-M1.jar > -rw-r--r--@ 1 roiocam staff 108779 6 11 15:34 > pekko-persistence-jdbc_2.13-1.1.0-M1-sources.jar > -rw-r--r--@ 1 roiocam staff 1802753 6 11 15:34 > pekko-persistence-jdbc_2.13-1.1.0-M1-javadoc.jar > -rw-r--r--@ 1 roiocam staff 574981 6 11 15:34 > pekko-persistence-jdbc_2.13-1.1.0-M1-RC2.jar > -rw-r--r--@ 1 roiocam staff 108783 6 11 15:34 > pekko-persistence-jdbc_2.13-1.1.0-M1-RC2-sources.jar > -rw-r--r--@ 1 roiocam staff 1804309 6 11 15:34 > pekko-persistence-jdbc_2.13-1.1.0-M1-RC2-javadoc.jar > -rw-r--r--@ 1 roiocam staff 569613 6 11 15:33 > pekko-persistence-jdbc_2.12-1.1.0-M1.jar > -rw-r--r--@ 1 roiocam staff 108779 6 11 15:33 > pekko-persistence-jdbc_2.12-1.1.0-M1-sources.jar > -rw-r--r--@ 1 roiocam staff 1830117 6 11 15:33 > pekko-persistence-jdbc_2.12-1.1.0-M1-javadoc.jar > -rw-r--r--@ 1 roiocam staff 569618 6 11 15:33 > pekko-persistence-jdbc_2.12-1.1.0-M1-RC2.jar > -rw-r--r--@ 1 roiocam staff 108783 6 11 15:33 > pekko-persistence-jdbc_2.12-1.1.0-M1-RC2-sources.jar > -rw-r--r--@ 1 roiocam staff 1831656 6 11 15:33 > pekko-persistence-jdbc_2.12-1.1.0-M1-RC2-javadoc.jar > > > Nicolas Vollmar <nvoll...@gmail.com> 于2024年6月11日周二 13:49写道： > > > I checked out the Tag v1.1.0-M1 and the reproducible build checks end with: > > > > [info] # `pekko-persistence-jdbc_2.13-1.1.0-M1.buildinfo`: NOT OK > > > > [info] > > > > [info] - pekko-persistence-jdbc_2.13-1.1.0-M1.pom: Match > > > > [info] - pekko-persistence-jdbc_2.13-1.1.0-M1.jar: Mismatch: our > > > > 08d2726b5b899bf6d90d2d27b51df755fccdf1f0e8a3f614653bc3ea1180e28366e4391e27f9e3b00aab750dcf0251db102666b5ebecc5845d0c0598e7c066ad > > did not match their > > > > 5976ad5a33faf045b26b38d1c7f4e548d91e65b382d5389e56b54834da9cbde47c9c814d1a109f6cf62c42fb47190d9888f6b123f3cb836f0eb3312941bf322d > > > > I've run our persistence tests (using H2) against 1.1.0-M1 and everything > > looks fine. > > > > > > On Mon, 10 Jun 2024 at 12:39, PJ Fanning <fannin...@apache.org> wrote: > > > > > Would anyone have time to look at this? It is the last step needed for > > > this release. > > > > > > One approach is to check if the build is reproducible from the git tag > > > (v1.1.0-M1). > > > > > > > > https://github.com/apache/pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build > > > > > > Scala 3 does not produce reproducible builds but Scala 2.12 and 2.13 do. > > > The Scala 3 issues are still open withe Scala team. > > > > > > Another approach to use a tool like jardiff to compare the v1.1.0-M1-RC1 > > > and v1.1.0-M1 jars. > > > https://github.com/lightbend-labs/jardiff > > > > > > The only diffs should be the version number (that appears in a few places > > > in files in the jar, eg MANIFEST.MF). > > > > > > > > > > > > > > > On 2024/06/06 21:37:30 PJ Fanning wrote: > > > > Hi everyone, > > > > The release vote has passed. The final requirement is to validate the > > > > Pekko Persistence JDBC 1.1.0-M1 jars. > > > > > > > > I have uploaded the 1.1.0-M1 jars to repository.apache.org staging > > repo. > > > > The 1.1.0-M1-RC2 jars are still there for comparison. > > > > > > > > I will leave the jars there for at least 24 hours. Our process > > > > requires that at least 1 PMC member reviews the jars before we can > > > > release them. > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > > > > > Thanks, > > > > PJ > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
