Our LICENSE is about our source code. It is not about jar dependencies. If we borrow source code from 3rd party source code then we need to reference this in our LICENSE. I see no such code borrowing in https://github.com/apache/pekko-connectors/commit/25a6f8cd2ce57b48420b42475b46b00acf72fcad
There are ongoing issues with build reproducibility, especially with Scala 3. Could you raise an issue in https://github.com/apache/pekko-connectors/issues ? On Tue, 9 Jul 2024 at 02:49, JingZhang Chen <roio...@apache.org> wrote: > > [X] Download links are valid. > [X] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [X] No unexpected binary files > [X] All source files have ASF headers > [X] Can compile from source > [ ] Can verify the binary build > > > we have been updated aws-sdk to version 2: > https://github.com/apache/pekko-connectors/commit/25a6f8cd2ce57b48420b42475b46b00acf72fcad > but the license is still aws-sdk-java version 1, do we need to update it in > `LICENSE`? > > Has issue at `reproducibleBuildsCheck` > > [error] > /Users/roiocam/runtime/downloads/vote/apache-pekko-connectors-1.1.0-M1-src-20240704/spring-web/src/main/java/org/apache/pekko/stream/connectors/spring/web/PekkoStreamsRegistrar.java:35:1: > ����: materializer���� @param > [error] public PekkoStreamsRegistrar(Materializer materializer) { > [error] ^ > > PJ Fanning <fannin...@apache.org> 于2024年7月9日周二 05:25写道： > > > Would anyone in the Pekko PMC have time to review this RC? > > > > Thanks, > > PJ > > > > On 2024/07/04 11:44:50 PJ Fanning wrote: > > > Hello Pekko Community, > > > > > > This is a call for a vote to release Apache Pekko Connectors > > 1.1.0-M1-RC1. > > > > > > The discussion thread: > > > > > > https://lists.apache.org/thread/7w0fhp068lomfmbg4h65ssbcvw83ds67 > > > > > > The release candidate: > > > > > > https://dist.apache.org/repos/dist/dev/pekko/CONNECTORS-1.1.0-M1-RC1/ > > > > > > This release has been signed with a PGP key available here: > > > > > > https://downloads.apache.org/pekko/KEYS > > > > > > Release Notes: > > > > > > https://github.com/apache/pekko-connectors/pull/717/files > > > > > > Git tag for the release: > > > > > > https://github.com/apache/pekko-connectors/tree/v1.1.0-M1-RC1 > > > Git commit ID: 52bad1de6d30254756aee3f1a04b104549ff2ee3 > > > > > > Please download, verify, and test. > > > > > > I have also staged jars in the Apache Nexus Repository. These were built > > > with the same code as appears in this Source Release Candidate. > > > I would appreciate if users could test with these too. > > > If anyone finds any serious problems with these jars, please also notify > > us > > > on this thread. > > > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > > > For sbt 1.9.4 or greater you can add this resolver > > > > > > resolvers += Resolver.ApacheMavenStagingRepo > > > > > > Otherwise for older versions of sbt > > > > > > resolvers += "Apache Pekko Staging" at " > > > https://repository.apache.org/content/groups/staging"; > > > > > > > > > The VOTE will pass if we have more positive votes than negative votes > > > and there must be a minimum of 3 approvals from Pekko PMC members. > > > Anyone voting in favour of the release, could you please provide a list > > of > > > the checks you have done? > > > The vote will be left open for at least 72hrs. > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > To learn more about Apache Pekko, please see https://pekko.apache.org/ > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > [ ] Checksums and signatures. > > > [ ] LICENSE/NOTICE files exist > > > [ ] No unexpected binary files > > > [ ] All source files have ASF headers > > > [ ] Can compile from source > > > [ ] Can verify the binary build > > > > > > To compile from the source, please refer to: > > > > > > > > https://github.com/apache/pekko-connectors/tree/main?tab=readme-ov-file#building-from-source > > > > > > To verify the binary build, please refer to: > > > > > > > > https://github.com/apache/pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build > > > > > > Some notes about verifying downloads can be found at: > > > > > > https://pekko.apache.org/download.html#verifying-downloads > > > > > > Here is my +1 (binding). > > > > > > Thanks, > > > PJ Fanning (Apache Pekko PMC member) > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
