I'm not against reverting https://github.com/apache/pekko-http/pull/590.
I'll go with the consensus but my slight preference is a revert of 590. On Mon, 9 Sept 2024 at 12:44, Matthew de Detrich <mdedetr...@gmail.com> wrote: > > > We can do a 1.1.2 release. Let's get the existing bug fix out. > The Pekko HTTP release is not urgent. It can be delayed while we > discuss https://github.com/apache/pekko/pull/1468 > > This I understand, my only counter argument is that it may take a while for > a 1.1.2 release > and I am basically blocked completely from addressing the ticket until such > a release is made. > > An alternative would be to just revert > https://github.com/apache/pekko-http/pull/590 and fix the > issue properly, which according to @Johannes Rudolph > <johannes.rudo...@gmail.com> can now be done (see > https://github.com/apache/pekko-http/issues/422#issuecomment-2334092975) > > On Mon, Sep 9, 2024 at 1:39 PM PJ Fanning <fannin...@gmail.com> wrote: > > > We can do a 1.1.2 release. Let's get the existing bug fix out. > > The Pekko HTTP release is not urgent. It can be delayed while we > > discuss https://github.com/apache/pekko/pull/1468 > > > > On Mon, 9 Sept 2024 at 12:37, Matthew de Detrich <mdedetr...@gmail.com> > > wrote: > > > > > > So sorry for throwing another thing on the release but if we want to > > > address the concerns around > > https://github.com/apache/pekko-http/pull/590 > > > then it makes sense for https://github.com/apache/pekko/pull/1468 to > > also > > > get merged for the Pekko 1.1.1 release since we need this ability > > > of overriding the timeout for specific tests in order to properly > > > gauge whether the increased stream-cancellation-delay timeout to 1 second > > > is going to have any adverse impact. > > > > > > On Sat, Sep 7, 2024 at 9:55 AM Arnout Engelen <enge...@apache.org> > > wrote: > > > > > > > Hello, > > > > > > > > https://github.com/apache/pekko/issues/1463 looks serious - as it > > might > > > > cause data loss/corruption when combined with persistence (which is > > > > common), perhaps we should roll back the website changes for 1.1.0 and > > > > prioritize releasing a 1.1.1 with (perhaps just) a fix/rollback for > > this > > > > issue? I can RM. > > > > > > > > > > > > Kind regards, > > > > > > > > -- > > > > Arnout Engelen > > > > ASF Security Response > > > > Apache Pekko PMC member, ASF Member > > > > NixOS Committer > > > > Independent Open Source consultant > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
