Sorry, I had kinda ignored https://github.com/apache/pekko-http/pull/597 because it was still in 'draft' state.
It seems clear this work is in an 'intermediate' state: we would like the get back into a state where the "stream.testkit.all-stages-stopped-timeout = 20 s" is no longer needed, ideally either by improving the implementation (so the cancellation delay is no longer needed) or by improving the tests (so they no longer rely on the cancellation delay?), or otherwise by increasing this value only for specific tests where it is needed. The question is what the risk of releasing with the "stream-cancellation-delay = 1000 millis" is. If this risk is low, it might be fine to release in this 'intermediate' state. If the risk is high, it would be safer to revert this change and live with the occasional 'SubscriptionWithCancelException$NoMoreElementsNeeded' until we find a more complete solution. Other than being ugly and possibly indicative of a deeper problem, these exceptions are essentially harmless, right? What worries me most is the "-o 9" that apparently had to be added to H2SpecIntegrationSpec. This is a fairly realistic 'end-to-end' test, and needing to move this from 2 to 9 seconds seems like quite a big jump. Based on that, though I generally favour 'rolling forward', in this case I think it would probably be wise to indeed do the revert (I'll also post this as a review on the PR) to unblock the release. Kind regards, Arnout On Wed, Sep 18, 2024 at 8:05 PM PJ Fanning <fannin...@apache.org> wrote: > > Would it be possible to merge the revert of PR 590. This is the large item > blocking this release - which in turn blocks other releases like gRPC and > Connectors. > * https://github.com/apache/pekko-http/pull/590 > * https://github.com/apache/pekko-http/pull/597 > > > On 2024/09/12 12:16:35 PJ Fanning wrote: > > Will we just revert 590 and proceed with the RC when Pekko 1.1.1 is out? > > > > I have https://github.com/apache/pekko-http/pull/597 > > > > We can always do a Pekko HTTP 1.1.1 with a fix or fixes to address this > > underlying issue. > > > > > > > > On 2024/09/06 17:03:46 Matthew de Detrich wrote: > > > Lets resolve the ongoing conversation at > > > https://github.com/apache/pekko-http/pull/590#pullrequestreview-2281514043 > > > before kicking off a release, as pointed out > > > by @Johannes Rudolph <johannes.rudo...@gmail.com> there is a slight risk > > > that this change may have made things worse. > > > > > > On Fri, Sep 6, 2024 at 1:55 PM PJ Fanning <fannin...@apache.org> wrote: > > > > > > > Would anyone have time to review > > > > https://github.com/apache/pekko-http/pull/584 ? > > > > > > > > It is the final PR to merge - or to choose not to merge - that is > > > > holding > > > > up this release process. > > > > > > > > On 2024/09/03 20:16:55 PJ Fanning wrote: > > > > > With Pekko Core 1.1.0 jars released, we can now start towards > > > > > releasing Pekko HTTP 1.1.0. > > > > > There is one PR open that I would like to merge. > > > > > * https://github.com/apache/pekko-http/milestone/4 > > > > > * https://github.com/apache/pekko-http/pull/584 > > > > > > > > > > There is some more work to do like setting up the release notes. > > > > > If anyone thinks that we need to delay the RC, get in touch. > > > > > If anyone wants to volunteer to be the Release Manager, I can assist > > > > > if required. I can act as Release Manager if noone else is available. > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > -- Arnout Engelen ASF Security Response Apache Pekko PMC member, ASF Member NixOS Committer Independent Open Source consultant --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
