On Thu, Dec 5, 2024 at 9:46 PM PJ Fanning <fannin...@apache.org> wrote: > https://github.com/apache/pekko-persistence-r2dbc/tree/v1.1.0-M1-RC1 > Git commit ID: 3b3953691d3adfbdef243a6ae4898b7d4efaed15 > > [x] Download links are valid. > [x] Checksums and signatures. > [x] LICENSE/NOTICE files exist > [x] No unexpected binary files > [x] All source files have ASF headers > [x] Can compile from source > [x] Can verify the binary build > > To compile from the source, the build instructions on the main Pekko > repo are useful. Java 8 is the recommended version for building Pekko > Persistence R2DBC. > > https://github.com/apache/pekko?tab=readme-ov-file#building-from-source > > To verify the binary build, please refer to: > > https://github.com/apache/pekko-site/wiki/Pekko-Release-Process#verifying-the-binary-build > > Some notes about verifying downloads can be found at: > > https://pekko.apache.org/download.html#verifying-downloads
* All artifacts successfully reproduce - in fact, they were even bit-by-bit reproducible when I built with jdk11, while the artifacts were built with jdk8. * I have not tested the component in any application There are some excludes in https://github.com/apache/pekko-persistence-r2dbc/tree/main/projection/src/main/mima-filters/1.0.x.backwards.excludes, from changes in https://github.com/apache/pekko-persistence-r2dbc/pull/177 and https://github.com/apache/pekko-persistence-r2dbc/pull/101 . Strictly speaking this means this release is not binary compatible in its public APIs, and should have version 2.0.0, right? I think I'm OK with allowing these changes without a major version bump, especially because these APIs are unlikely to be used from a library, and instead would be used directly from 'leaf' applications. If we plan on doing/allowing this more often, we should document it in https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html . This is my +1 Kind regards, -- Arnout Engelen ASF Security Response Apache Pekko PMC member, ASF Member NixOS Committer Independent Open Source consultant --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
