Thanks Arnout. I will proceed with the release of the jars but I agree that we will need to get to the bottom of the reproducibility issues for future releases.
On 2025/01/15 13:00:57 Arnout Engelen wrote: > Comparing the jars revealed at least one difference: between > pekko-connectors-google-cloud-pub-sub-grpc_2.12-1.1.0-RC1.jar and > pekko-connectors-google-cloud-pub-sub-grpc_2.12-1.1.0-RC1.jar, the > vendored google protobuf files (both .protos and generated classes) > are different. Actually different: for example, the > google.rpc.BadRequest.localized_message field appears in the release > version but not in RC1. The same seems to go for > google-cloud-bigquery-storage. I filed > https://github.com/apache/pekko-connectors/issues/953 for this issue, > though I suspect it might have the same root cause as > https://github.com/apache/pekko-connectors/issues/738 > > Again a few instances of > https://github.com/apache/pekko-connectors/issues/739 which we hope to > see fixed in Scala 3.3.5 > > pekko-connectors-s3_2.13-1.1.0.jar appears to have some differences I > can't quite place yet: > > │ │ - final S3Ext s3Extension = (S3Ext)S3Ext$.MODULE$.apply(sys); > │ │ + final S3Ext s3Extension = > (S3Ext)ExtensionId.apply$((ExtensionId)S3Ext$.MODULE$, sys); > > While I think it's important we work towards fixing these issues, this > is my reluctant +1 on the binaries. > > > Kind regards, > > Arnout > > On Tue, Jan 14, 2025 at 7:39 PM PJ Fanning <fannin...@apache.org> wrote: > > > > Hi everyone, > > The release vote has passed. The final requirement is to validate the > > Pekko Connectors 1.1.0 jars. > > > > Built from tag: > > https://github.com/apache/pekko-connectors/releases/tag/v1.1.0 > > > > I have uploaded the 1.1.0 jars to repository.apache.org staging repo. > > The 1.1.0-RC1 jars are still there for comparison. > > > > I will leave the jars there for at least 24 hours. Our process > > requires that at least 1 PMC member reviews the jars before we can > > release them. > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/ > > > > Thanks, > > PJ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > -- > Arnout Engelen > ASF Security Response > Apache Pekko PMC member, ASF Member > NixOS Committer > Independent Open Source consultant > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
