On Tue, 29 May 2001, barries wrote: > I know you don't need *FunctionTable.pm, but hey, it's free. thanks, concept is good, but xsub mapping is off a bit. we do need the ModPerl::FunctionTable entries. for these xsubs, pTHX_ is not needed, and we know the number of arguments. > +MP_INLINE int modperl_output_filter_eof(pTHX_ > + modperl_filter_t *filter); > + > +MP_INLINE int modperl_output_filter_tell(pTHX_ > + modperl_filter_t *filter); > + > +MP_INLINE int modperl_output_filter_close(pTHX_ > + modperl_filter_t *filter); > + so these (or something like them, should have no pTHX_, with the proper ModPerl::FunctionTable entry, modperl_functions.map only needs the name of the function. > +static MP_INLINE int mpxs_Apache__Filter_eof(pTHX_ I32 items, > + SV **MARK, SV **SP) this style (items,MARK,SP) should only be used for variable argument functions, like read/print. > + mpxs_Apache__Filter_eof | | ... > + mpxs_Apache__Filter_tell | | ... > + mpxs_Apache__Filter_close | | ... so these should really just be: modperl_filter_eof modperl_filter_tell modperl_filter_close --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
