On Tue, 12 Jun 2001, Geoffrey Young wrote:

> doh! this breaks the api.t test.
> 
> hmm, the test calls $r->custom_response(403) - no second parameter.
> 
> my C friends here tell me that being able to call custom_response with only
> one argument works only by accident.  I dunno.

no accident, done to fetch the current custom response.

> at any rate, $r->custom_response(VAL) isn't documented as far as I can tell
> (although I have also used it that way myself) and a quick grep of CPAN
> doesn't show it used this way there as well...

i remember somebody asking for it way back, but not surprised it never got
doced.
 
> anyway, short of disallowing the single parameter form of custom_response
> (which would mean that you could never just inspect the current
> ErrorDocument setting), does 
> anyone have an ideas how to implement (what I think, at least) would be the
> proper behavior:
>   one arg - return current config
>   two args, second arg defined - set config
>   two args, second undef - reset default response

behavior looks right.
probably would need to add a reset flag parameter for custom_response(),
set to 1 if ST(2) == &sv_undef


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to