> > 
> > just out of curiosity, I tried to get the method name from 
> the gv returned
> > from sv_2cv using GvNAME and kept segfaulting, then I 
> noticed you never used
> > that gv in similar calls... is that gv unreliable?
> 
> not sure, but CvGV(cv) should be reliable.

yeah, that's working fine.

> 
> > +    is_method = perl_cv_ismethod(cv);

do I need some sort of check on cv before calling perl_cv_ismethod(cv) here?

> > +
> >      if (!is_method && (cv && SvPOK(cv))) {
> >         is_method = strnEQ(SvPVX(cv), "$$", 2);
> >      }
> 
> perl_cv_ismethod should also include this $$ prototype check, no?
> otherwise looks good.

oh, right... I'll pull that out of perl_handler_ismethod too and stick it in
the new function...

I guess the last thing is - how do I check my refcounts to make sure I got
all the dec and inc stuff right?

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to