On Wed, 5 Sep 2001, Doug MacEachern wrote:

> On Tue, 4 Sep 2001, Stas Bekman wrote:
>
> > I also have a question regarding apr_table_t. When creating the table with
> > apr_table_make one has to specify nelts. But then it grows automatically
> > as required (right?), so what's the point of nelts then? pre-alloc? In any
> > case what netls should I use for env vars table? I've used 2.
>
> yes, purpose of nelts is to pre-alloc.
> your patch looks good, but i want to hold off for the moment.  for the
> same reason i've not gone forward with implementing this yet.  we need to
> change things to env stuff does not modify the underlying C environ array
> until an actual fork happens that will need to have environ modified.
> this is for both performance and i'm pretty sure it isn't thread safe to
> modify environ in concurrent threads.

I've to get more into the threading stuff...

Can we at least add the configuration bits support and leave the actual
env setting for the later on? I want to do that, because my patch
introduces new TAKE wrappers which are re-used for other new directives.
So we can parse these vars, populate the tables, do the merge, but keep
the env setting empty for now.

One another thing I've planned to implement is PerlSetVar. I assume that
this one is safe to implement disregarding thread issues, right?

_____________________________________________________________________
Stas Bekman              JAm_pH     --   Just Another mod_perl Hacker
http://stason.org/       mod_perl Guide  http://perl.apache.org/guide
mailto:[EMAIL PROTECTED]   http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to