On Sat, 15 Sep 2001, Philippe M . Chiasson wrote:
 
> Right now, my patch implements filtering on the modperl side with apr_tables to
> hold the filter list, but the best solution would be to call vdo directly, but
> I've read in many places that there is no way to fake a va_list to pass along
> to vdo.

right, i don't know of a way to create a va_list either.
 
> Possible solution would be to reenginer the vdo function in apr to accept
> a char * array and change apr_table_do to generate that array from the va_list,
> that way, we could call it directly with a filter list and not have to do it
> again.  Is it a good idea ? souldn't be that hard to do without breaking httpd ;p

or we could just have our own vdo, that uses MARK/SP directly.
 
> 1:  Why dTHX should be avoided whenever possible ?

expensive, uses thread local storage.

> 2:  If so, I can remove it from the mpxs_apr_table_do entry point, but I'll have
>     to use it in the callback function anyways, unless I can somehow stash these
>     variables into the callback data struct, but I am _really_ not sure about that.

see the change after your patch, same way APR::Pool cleanups are
implemented.
 
> Hope this one looks better...

much.  i still made a few minor style changes though :-)
thanks!


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to