On Sat, 15 Sep 2001, Stas Bekman wrote:

> 
> OK, here is the patch that:
> 
> - adds the writefile sub to genfile+throw content in
> - adds a scan for APACHE_TEST_CONFIGURE and its execution

those both look good, how about if you go ahead commit both as separate
patches?

> - implements the PerlRequire test

let's wait on committing this until the ugly parts are sorted out.
 
> the ugly parts:
> 
> - I wish PerlSwitches were working with +Parent, so I didn't have to do
>   the ugly hack with adding yet another PerlRequire

can you write up a small test case with expected/actual results?
 
> - +Parent, doesn't worry to load the test INCs so every test has to do it
>   manually, would be nice to do it in-core

expected.  the vhost should PerlRequire modperl_startup.pl or whatever it
needs (e.g. conf/modperl_inc.pl)

> - +Parent doesn't clean @INC from the main interpreter, run the test:
>   ./t/TEST -v directive/perlrequire
>   and check the error_log -- you will see that VH includes the INC path
>   defined in the main interpreter. I'm talking about:
>   /home/stas/apache.org/registry/t/htdocs/testdirectives/main
>   generated by:
>   +PerlSwitches -Mlib=@documentroot@/testdirectives/main

expected, since you did not define a PerlSwitches in your vhost.
however, it used to be that PerlSwitches was _not_ inherited, i
"fixed" that when you complained it was not inherited in the past.
let's decide, should PerlSwitches be inherited if not defined in the
vhost?




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to