On Sat, 29 Sep 2001, Stas Bekman wrote:

> 
> this patch:
> - implements modperl_table_get_set for other functions to use
> - implements Apache::Server::dir_config + tests
> - implements Apache::RequestRec::dir_config + tests
> - implements new features coming from modperl_table_get_set for free
>   $(s|r)->dir_config($key => $val);   # == set($key, $val)
>   $(s|r)r->dir_config($key => undef); # == unset($key)
> - adds tests for PerlSetVar and PerlAddVar via dir_config

great!
 
> open issues: Apache::Server doesn't bootstap subs from Apache::ServerUtil
> (doesn't use/require), I've done this with use() in the test, where I
> needed it. Not sure what's the right thing to do here.

that's right, you need to 'use Apache::ServerUtil ()' for
Apache::Server::dir_config to be available.

i only gave it a quick skim, but it looks good, i've got to head out now.
+1 here to commit.  good work stas!



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to