On Fri, 28 Sep 2001, Stas Bekman wrote: > issues: > - missing ALIAS for Apache::Server::dir_config (don't know how to make it > work with auto-auto-auto-generator :)
add the common function to modperl_util.c, then it can be called from anywhere. > - this patch is weird as it includes 3 different implementations of > dir_config, dir_config_old, dir_config_xs - please pick the right one. > the test actually tests only dir_config, but they all should work. dir_config with the (table, key=NULL, val=NULL) prototype. > - perl_get_startup_server() from 1.x, I couldn't find it in 2.x (probably > it's not implemented yet, so it's in the comment XXX) its called modperl_global_get_server_rec(); in 2.0 if you could resubmit with just the 1 dir_config implementation that would make it much easier to review, thanks :) --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
