On Fri, 28 Sep 2001, Stas Bekman wrote: > patch: > - this patch implements PerlSetVar and PerlAddVar > > changes: > - the first patch was broken, you cannot use apr_table_overlap for merging > SetVar tables(in merge_table_overlap_item) , because we want to overlap > only the values for the keys which arenot in the current dir_config table. > So I had to do it manually. Do you think we should submit a patch for > apr_table_overlap, to have a third flag that does what we want?
sure. but, in 1.x we just use overlay_tables, why do we need to change? will the change break anything expecting 1.x behavior? can you give an example of whats going on here? (i'm not really familar with what to expect here) > - now the test in the next patch (of dir_config) is done properly and > tests the failure I didn't notice in the previous patch. > + modperl_config_dir_t *dcfg = (modperl_config_dir_t *)dummy; as mentioned before, you need to cvs up, dummy has been renamed mconfig. > +/* take the 'base' values, and override with 'add' values if any */ > +#define merge_table_overlap_item(item) \ this should be a MP_INLINE-d function. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
