On Sat, 13 Oct 2001, Randy Kobes wrote:

> Hi,
>     Attached is a diff for modperl-2.0/Apache-Test/ as a first
> stab at getting it to work on Win32. The changes include:
> 
> - TestMM.pm: in creating the run_tests target, Win32 doesn't
> understand prefixing the command with the environment
> variables, so this was changed for Win32.

i made the change a little different, so that PASSENV is just empty if
WIN32.  does that work ok?

> - TestConfig.pm: setting $vars->{target} to Apache.exe for
> Win32;
> - TestServer.pm: using Win32::Process to start and stop
> the server;

nice.  just moved the object to live in $config instead of $config->{vars}

> As well, Apache.exe must be in the PATH beforehand.

should we add the default install path if it isn't already in PATH?

> All things considered, these are suprisingly simple changes,
> attesting to the quality of the code ... With these, the generated
> tests pass (with Apache-1.3.20).

fantastic, thanks randy!!



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to