Doug MacEachern wrote:

> On Sat, 8 Dec 2001, Stas Bekman wrote:
>  
> 
>>no more dTHXs in APR PerlIO layer (at least so far), but they are used
>>internally in the base PerlIO layer to do XS.
>>
> 
> right.  but if that perl function took a pTHX_ (like many of the
> others do) then there would be no need for dTHX;


yes of course.


>>>>todo, I guess I need to provide an XS constant that says whether
>>>>
>>PerlIO is available, right?
>>
> 
> you can do this now:
> plan tests => $tests, have_perl 'iolayers';


thanks :)


>>+    st->pool = modperl_global_get_pconf();
>>
> 
> hope you can find a good solution for this problem.  aside from not being
> able to use pconf after startup time, we cannot reference that function
> else APR::PerlIO will not work outside of httpd.


yes, I understand that. It probably will take some time. But it doesn't 
stop us from using PerlIO with modperl_global_get_pconf() in dev.


>>+void apr_perlio_BOOT(pTHX)
>>
> 
> minor nit: would rather have that called apr_perlio_initialize()
> or apr_perlio_init().  BOOT just happens to be when we call it in xs, not
> what it actually does.


done


> looks good, +1 on committing.  other issues can be worked out later.


great!


_____________________________________________________________________
Stas Bekman             JAm_pH      --   Just Another mod_perl Hacker
http://stason.org/      mod_perl Guide   http://perl.apache.org/guide
mailto:[EMAIL PROTECTED]  http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to