hi all...
well, I thought I'd try to help give the 1.3 tree some forward momentum...
my thought is to run through the STATUS file and present all the available patches
for
review and incorporation into core, and I thought I'd start with one I was pretty
familiar
with :)
PerlSetEnv seems not to work for any requests after the first request to a particular
child - see the links in the STATUS file for the bug report, as well as the surrounding
discussion (the bug was discovered as part of trying to fix another problem)
I traced the problem through the code and the fix seems pretty simple (in
mod_perl.c).
I added a test in t/net/perl/api.pl that fails without the patch but passes ok with it.
at any rate, all other tests pass.
I'm hoping to present one or two patches a week until at least the available patches
board is cleared from the STATUS file - I hope that helps somewhat.
--Geoff
Index: t/net/perl/api.pl
===================================================================
RCS file: /home/cvs/modperl/t/net/perl/api.pl,v
retrieving revision 1.47
diff -u -r1.47 api.pl
--- t/net/perl/api.pl 6 Jul 2001 16:09:53 -0000 1.47
+++ t/net/perl/api.pl 18 Mar 2002 18:17:02 -0000
@@ -16,7 +16,7 @@
my $is_xs = ($r->uri =~ /_xs/);
-my $tests = 74;
+my $tests = 75;
my $is_win32 = WIN32;
$tests += 4 unless $is_win32;
my $test_get_set = Apache->can('set_handlers') && ($tests += 4);
@@ -94,6 +94,7 @@
test ++$i, $r->last;
test ++$i, $ENV{GATEWAY_INTERFACE};
+test ++$i, defined $ENV{KeyForPerlSetEnv};
test ++$i, scalar $r->cgi_var('GATEWAY_INTERFACE');
test ++$i, defined($r->seqno);
test ++$i, $r->protocol;
Index: src/modules/perl/mod_perl.c
===================================================================
RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.c,v
retrieving revision 1.141
diff -u -r1.141 mod_perl.c
--- src/modules/perl/mod_perl.c 10 Jul 2001 03:30:27 -0000 1.141
+++ src/modules/perl/mod_perl.c 18 Mar 2002 18:17:02 -0000
@@ -1392,6 +1392,7 @@
/* PerlSetEnv
* update only if the table changes across a request
*/
+ MP_HASENV_on(cld);
mod_perl_dir_env(r, cld);
cfg->dir_env = cld->env;
}
Index: STATUS
===================================================================
RCS file: /home/cvs/modperl/STATUS,v
retrieving revision 1.1
diff -u -r1.1 STATUS
--- STATUS 2 Mar 2002 18:09:54 -0000 1.1
+++ STATUS 18 Mar 2002 18:17:02 -0000
@@ -21,15 +21,6 @@
Status:
doc patch at
http://marc.theaimsgroup.com/?l=apache-modperl&m=97450363501652&w=2
- * PerlSetEnv scoping
- Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=99148497206388&w=2
- Status:
- may be fixed here
- http://marc.theaimsgroup.com/?l=apache-modperl&m=99473571809129&w=2
- but that patch has this issue (I think)
- http://marc.theaimsgroup.com/?l=apache-modperl&m=99565226811557&w=2
- --Geoff
-
* %LocationMatch <Perl> bug
Report: http://marc.theaimsgroup.com/?l=apache-modperl&m=98260537428737&w=2
Status:
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
