On Tuesday 26 March 2002 15:31, Eric Cholet wrote: > --On Monday, March 25, 2002 11:04:02 -0800 Doug MacEachern > > what we've done with escape_html already (diverging from apache) is just > > plain wrong. i don't want to take it any further. this should be > > implemented properly for 2.0 (in apache) and/or HTML::Entities can be > > written in xs. modperl is not the right place to implement this > > functionality. > > How about adding this to the doc for escape_html: > > This function will correctly escape ASCII output. If you're using > a different character set such as UTF8, or need more control on > the escaping process, use HTML::Entities.
Sorry I missed the beginning of the thread due to being busy and could only salvage the end from my trash. However, I get the gist and I think that Eric's suggestion works well (with the tiny nit that I'd make that US-ASCII instead of ASCII for the sake of correctness). escape_html() as it is now does indeed have a potential for causing breakage, but fixing it on modperl's side is a task that's somewhere between quite hard and impossible. Imho a simple docpatch as the above is the way to go. -- _______________________________________________________________________ Robin Berjon <[EMAIL PROTECTED]> -- CTO k n o w s c a p e : // venture knowledge agency www.knowscape.com ----------------------------------------------------------------------- Don't panic. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
