Geoffrey Young wrote: > > > Stas Bekman wrote: > >> Geoffrey Young wrote: >> >>> >>> >>> Stas Bekman wrote: >>> >>> > there are taint mode problems with modperl-1.x and the latest >>> > bleadperl (testing with 15887). >>> > >>> > In addition to the taint bugs in Cwd that I'm trying to solve (see >>> > my report at p5p, including a partial patch), there is another >>> > taint problem when trying to start mod_perl 1.x cvs's 'make test' >>> > >>> > In the t/logs/error_log you get simply: Insecure dependency in eval >>> > while running with -T switch. and the server won't start. >> >> >> >> BTW, update your bleadperl, one of my patches was applied already (the >> other pending is irrelevant to modperl at this moment). > > > > I did that this morning - I don't think your patch made it to rsync yet :)
Really? that's weird. Try this: http:[EMAIL PROTECTED]/msg77510.html >> cool Geoff :) I didn't think of using TRACE :) But we still don't know >> if the problem happens in INET.pm or after it because the trace is >> printed before the require and not after it. >> >> MP_TRACE_g(fprintf(stderr, "reloading %s\n", HeKEY(entry))); >> perl_require_pv(HeKEY(entry)); > > > > well, when I traced the code, "Callback called exit" happens in > perl_eval_sv, which is called by perl_require_pv. of course, other > things can call it too, but I figured not much else was happening in > that loop other than just requiring lots of modules - on my system > Exporter is next in the chain. > > nevertheless, this addition to perl_util.c > > @@ -504,6 +504,7 @@ > HeVAL(entry) = &sv_undef; > MP_TRACE_g(fprintf(stderr, "reloading %s\n", HeKEY(entry))); > perl_require_pv(HeKEY(entry)); > + MP_TRACE_g(fprintf(stderr, "done with %s\n", HeKEY(entry))); > } > SvREFCNT_dec(keysv); > } > > yields > > reloading ExtUtils/testlib.pm > done with ExtUtils/testlib.pm > reloading URI.pm > done with URI.pm > reloading IO/Socket/INET.pm > Insecure dependency in eval while running with -T switch. > Callback called exit. > > however, if I comment out the INET.pm load in IO::Socket, then it fails > on reloading Exporter.pm. > > so, something strange is going on :) well, at least we know where this happens. It's probably that INET.pm and Exporter go through the same path somewhere. Try to set a breakpoint in the taint checking function (just before you call perl_eval_sv) and then trace back to the offender. Any idea about my side-effect question - how to make Perl_croak, do Croak::confess for the C/XS code? This would give us the problematic code immediately. __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
