If I build 2.0 using MP_APXS I get a bunch of warnings:

   Use of uninitialized value in -d at lib/Apache/Build.pm line 77.

since I don't set MP_AP_PREFIX and the code doesn't check if it's set 
and uses it in -d op.

should the MP_APXS be dropped, or the above adjusted to? :

Index: lib/Apache/Build.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/Build.pm,v
retrieving revision 1.93
diff -u -r1.93 Build.pm
--- lib/Apache/Build.pm 23 May 2002 23:36:31 -0000      1.93
+++ lib/Apache/Build.pm 28 May 2002 15:10:52 -0000
@@ -72,6 +72,8 @@
  sub ap_prefix_is_source_tree {
      my $self = shift;

+    return unless exists $self->{MP_AP_PREFIX};
+
      my $prefix = $self->{MP_AP_PREFIX};

      -d $prefix and -e "$prefix/CHANGES";

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to