Doug MacEachern wrote: > On Fri, 31 May 2002, Stas Bekman wrote: > > >>But isn't this ifdef test one sided? i.e. you test only if perl was >>compiled with USE_LARGE_FILES, but not APR. Shouldn't it be: >> >>#ifdef USE_LARGE_FILES && !APR_HAS_LARGE_FILES > > > didn't know there was an APR_HAS_LARGE_FILES
neither did I, but I took a chance with grep ;) > adjusted to not croak if APR_HAS_LARGE_FILES is true. this is a nice set of macros! Shouldn't the test be changed too to use MP_LARGE_FILES_PERL_ONLY? Should we provide perl constants for all these new macros? >>is there some workaround for this problem? or the only solution is to >>make sure that users compile both with largefiles support? If not, does >>it mean that it renders APR::PerlIO::seek useless, since the code is >>becoming not portable? > > > not sure if there is a portable workaround. are largefile size Off_t > simply cannot fit into a non-largefile size apr_off_t. > but am sure we cannot force that apr be compiled with largefile support, > nor can we force perl to be compiled with largfile support disabled. > not too worried about it at the moment. focusing on getting the tests to > pass on all platforms, APR::PerlIO::seek is a nice-to-have, but not a > requirement. I wasn't really talking about the test suite but about real apps that may need to use that feature if they need to interract with APR IO. Our goal is not only to make the test suite working ;) I think the more guiding we get in the error message the less questions will be asked.: Since APR::PerlIO::seek will work properly if either both apr and perl are built with large files support, or both without, we need to tell the user why the seek is failing and how to solve the problem, so the croak needs to be changed to something like: "PerlIO::APR::seek with non-zero offset, either rebuild Perl with -Uuselargefiles, or rebuild APR with -xxx" (xxx=large files support) I couldn't figure out what's the flag to enable large files with APR. __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
