Doug MacEachern wrote: > On Mon, 12 Aug 2002, Stas Bekman wrote: > > >>it failed to create the wrapper because the API included an 'int *' >>arg, whose typemap was undefined. Is it safe to use 'int * | PTR' >>typemap? I've checked the conversion functions and they seem to do the >>right thing: > > > that's fine for the typemap.
added >>that's said should the XS generator generate a fatal error when an XS >>wrapper is not created, because one of the argument's typemap is unknown? > > > maybe. i found it better the way it is now for early development, using > the util/xs_check.pl to tell me whats not getting mapped in a summary. are we still in the early development? >>in any case, the automatic wrapper now gets added. But its arguments are: >> >>const char * >>ap_get_remote_host(conn, dir_config, type, str_is_ip) >> Apache::Connection conn >> void * dir_config >> int type >> int * str_is_ip >> >>should the wrapper accept $r instead of $c (requiring a manual wrapper)? > > > no. should be able to use $c->get_remote_host(...) in a protocol handler > that does not have an $r. but the Apache::compat method can take care of > that. > > >>should we NULL the str_is_ip argument? > > > default to NULL, i think. i don't actually know what it is used for. > looks like dir_config should also default to NULL. > and type to REMOTE_NAME (like 1.x). > with $dir_config and $str_is_ip being optional args after type. I doubt mod_perl programmers will find any use for $str_is_ip. So I've added a wrapper ala mod_perl 1.0, plus an optional dir_config arg: mpxs_Apache__Connection_get_remote_host | | c, type=REMOTE_NAME, dir_config=Nullsv and the 1.0 wrapper in compat. Hope it's OK. __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
